Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Objects with the mouse goes wrong #429

Closed
StingMcRay opened this issue Jun 28, 2022 · 7 comments · Fixed by #431
Closed

Copy Objects with the mouse goes wrong #429

StingMcRay opened this issue Jun 28, 2022 · 7 comments · Fixed by #431
Assignees
Labels
anno canvas Issues affecting the anno canvas bug Something isn't working

Comments

@StingMcRay
Copy link
Contributor

Copy/Paste and clearing the mouse pointer on Anno Designer 9.2 has some issues when doing this with the mouse, Copy/Paste clearing mouse pointer (esc) with the key strokes are doing it oke, no problems there..

how to reproduce :
1 : selected 2/3 objects
2 : click on the middle mouse button (to copy and rotate 90 degrees)
3 : place the copied objects somewhere else,, click left mouse button to place them.
4 : move mouse to an other location and click the right mouse button (to release the mouse pointer)

result : you will see that where the original objects where are now on the mouse pointer from step 4
if you try to select those objects it will not been selected.
This should not be the behavior of the copy with mouse buttons, the original objects should stay where they where from step 1,
and the clear mouse pointer should not place or move those selected and copied original objects.

@FroggieFrog
Copy link
Collaborator

I can confirm the issue and add some images to clarify.
Version 9.1 does not have the issue, but version 9.2 has it and the current main branch also has it.

Version 9.1

  Click to expand!

rotate_91

Version 9.2+

Click to expand!

rotate_92

@FroggieFrog FroggieFrog added this to the Anno Designer 9.4 Release milestone Jun 29, 2022
@StingMcRay
Copy link
Contributor Author

Then we need to loop back what is changed from 9.1 to 9.2 what cost this issue...

@FroggieFrog
Copy link
Collaborator

It is not that easy.
But from what I understand it is caused by some changes of the QuadTree (which I still not fully understand).
So my best guess is that @Atria1234 needs to have a look at this.

The method AnnoCanvas.TryPlaceCurrentObjects() could be a good starting point.

@StingMcRay StingMcRay added bug Something isn't working anno canvas Issues affecting the anno canvas labels Jun 29, 2022
@Atria1234
Copy link
Collaborator

@FroggieFrog could you provide list of commands used to reproduce this? I see:

  1. Select objects
  2. ??? (which cause selection to copy to mouse cursor while also rotating?)
  3. Place down objects in cursor

And after being done

  • selected objects in step 1. are still copied to mouse cursor
  • both original and new copy of selected objects are on canvas and selectable

@FroggieFrog
Copy link
Collaborator

  1. select objects by mouse (yellow circle around cursor means left button is pressed)
  2. press middle mouse button (blue circle around cursor means middle button is pressed)
  3. place objects with left mouse button
  4. try to clear objects from cursor with right mouse button (red circle around cursor means right button is pressed)

@Atria1234
Copy link
Collaborator

Appears to be clone of #396

Caused by 621d458#diff-9356fda68a12ab98d19dae0d5982f1b8f8aa126b2808d456f3bb3f90fa5aef14R2696 . Easy fix.

@StingMcRay
Copy link
Contributor Author

Appears to be clone of #396

Sorry i thought this was an other issue
Thanks for fast fix :) (ofc need to be checked)

FroggieFrog added a commit that referenced this issue Jul 7, 2022
…ts (#431)

* SelectedObjects are clones instead of just copied to the CurrentObjects #429 #396
* add test

Co-authored-by: FroggieFrog <FroggieFrog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anno canvas Issues affecting the anno canvas bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants