Update merra2_thompson from Dom #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update order of variable definition files in ccpp/config/ccpp_prebuild_config.py * Remove duplicate variables in ccpp/data/GFS_typedefs.meta
… suite definition files (NOAA-EMC#371) * address error entered in stochastic_physics_wrapper.F90 that broke the ca restart reproducibility * Remove scheme rayleigh_damp from all remaining suite definition files Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
* io/FV3GFS_io.F90 updated to use fms2_io * atmos_model.F90 and ccpp/data/GFS_typefs.F90 updates to input_nml_file handling * atmos_cubed_sphere submodule updated
This PR brings in the latest release candidate for the FV3 dycore for use in the UFS. This PR will change answers for regional tests as well as any test using ICs generated from specific sources to chgres (when data_source_fv3gfs=.TRUE. logical within the dycore external_ic)
1. changes in NCAR/ccpp-physics#721 (sfcsub.F land-mask bug fix)
… feedback to FV3ATM (NOAA-EMC#376) Add a cplocn2atm namelist option to turn on/off the ocean model component feedback (e.g., SST) to the atmosphere model component.
…s.2021.03, IAU bug fix for restart files (NOAA-EMC#379) * CCPP metadata bugfixes in ccpp/data/GFS_typedefs.meta * fix the restart interval for iau Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov>
* Clean up ccpp/CMakeLists.txt, because the associated PRs for ccpp-framework and ccpp-physics now define their targets and dependencies correctly.
* Move the CMake build of the dycore from fv3atm into GFDL_atmos_cubed_sphere * Clean up the fv3atm CMakeLists.txt Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
…EMC#391) * update ccpp with CCPP PR#731 * add FV3 standalone P7 suite file * fix the filename with full time stamp for netcdf output
* update ccpp with decomposition fix
…OAA-EMC#402) Substantial changes in UGWPv1 to fix problem of lack of reproducibility when changing the domain decomposition layout.
…C#396) * This PR contains updates for new ca code, it fixes the CA restart and decomposition issues. Code changes are also in CCPP physics PR and stochastic physics PR.
* remove unused coupled suites * delete v15p2 coupled suites * update filename when the output time is not integer hours * fix the diag time issue with output_fh Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
…nteger arrays without affecting input/output files (NOAA-EMC#388) * Make real vegetation, slope and soil type integers, remove unnecessary interstitial arrays * Add interstitial variables to save and restore vegetation/soil/slope types before/after surface physics * Make vegetation/soil/slope save variables persistent so that they can be used in the _init phases * Only allow nearest-neighbor interpolation method for integer data * Remove legacy code from CMakeLists.txt
…NOAA-EMC#406) * Ensure timestamp of imported fields is set before checking the time. * Add missing specialization method to verify import fields for run phase 1.
|
Dom,
Never mind. I have just found that merra2_thompson of fv3atm is more
up_to_date with your modifications. I have also bring mraerosl of
ufs_weather_model up_to_date and the code has passed compilation and
waiting for the regression test for merra2_thompson in
/scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
The other change is that I treat merra2_aerosol_aware as parallel to
is_aerosol aware in mp_thompson.F90. I do not understand why you move
merra2_aerosol_aware to the beginning of the code before any
initialization.
Anning
On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
… HI, Dom:
my branch for fv3atm is mraerosol too. merra2_thompson is the old version,
out of date. Could you correct it?
On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
wrote:
> Yes, your branch that you gave me was merra2_thompson for fv3atm
>
> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> >
> >
> > HI, Dom,
> >
> > I merged, but the head of my branch of fv3atm "mraerosol" is still
> > at d840d47. Am missing something?
> >
> >
> >
> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > wrote:
> >
> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> please
> review and
> > > merge if ok. Thanks!
> > > ------------------------------
> > > You can view, comment on, or merge this pull request online at:
> > >
> > > #1
> > > Commit Summary
> > >
> > > - CCPP framework update and metadata bug fixes (#367)
> > > <
> 16a51fc
> >
> > > - Fix stochastic physics restart runs, remove rayleigh damping from
> > > all suite definition files (#371)
> > > <
> 862fe80
> >
> > > - Updates to use FMS 2021.03 (#374)
> > > <
> 2dc03c1
> >
> > > - brings in latest release candidate for the FV3 dycore (#377)
> > > <
> 7a97256
> >
> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > <
> 2fe2998
> >
> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> > > component feedback to FV3ATM (#376)
> > > <
> 967b84b
> >
> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3 files with
> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > <
> e5dfdd5
> >
> > > - Cleanup CCPP cmake build (#383)
> > > <
> 85c2648
> >
> > > - establish branch mraerosol
> > > <
> 53f3c0d
> >
> > > - cmake in the FV3 dycore (#389)
> > > <
> 026138b
> >
> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite file
> (#391)
> > > <
> d77f748
> >
> > > - update ccpp with decomposition fix (#397)
> > > <
> 06e9b35
> >
> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from CODEOWNERS
> > > (#402)
> > > <
> 931f8a3
> >
> > > - updates associated with CA restart and PE decomposition bugs (#396)
> > > <
> 376d374
> >
> > > - fix the output file name and diag time (#404)
> > > <
> 799b157
> >
> > > - Convert real(kind_phys) vegetation, slope and soil type arrays into
> > > integer arrays without affecting input/output files (#388)
> > > <
> b811a6c
> >
> > > - Properly import coupling fields when running with separate run
> > > phases (#406)
> > > <
> 95ff1ca
> >
> > > - Add consistency check for Thompson aerosol options to
> > > GFS_typedefs.F90
> > > <
> 2d50c61
> >
> > > - Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into
> > > HEAD
> > > <
> b79caf4
> >
> > > - Revert change to .gitmodules and update submodule pointer for
> > > ccpp-physics
> > > <
> cfc57d0
> >
> > >
> > > File Changes
> > >
> > > - *M* .gitignore
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> >
> > > (10)
> > > - *M* .gitmodules
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> >
> > > (20)
> > > - *M* CMakeLists.txt
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> >
> > > (109)
> > > - *M* atmos_cubed_sphere
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> >
> > > (2)
> > > - *M* atmos_model.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> >
> > > (51)
> > > - *M* ccpp/CMakeLists.txt
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> >
> > > (31)
> > > - *M* ccpp/data/GFS_typedefs.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> >
> > > (572)
> > > - *M* ccpp/data/GFS_typedefs.meta
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> >
> > > (114)
> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> >
> > > (32)
> > > - *M* ccpp/framework
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> >
> > > (2)
> > > - *M* ccpp/physics
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> >
> > > (2)
> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> >
> > > (88)
> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> >
> > > (90)
> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> >
> > > (88)
> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> >
> > > (93)
> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> >
> > > (11)
> > > - *M* cpl/module_block_data.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> >
> > > (35)
> > > - *M* fv3_cap.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> >
> > > (73)
> > > - *M* io/FV3GFS_io.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> >
> > > (881)
> > > - *M* io/module_fv3_io_def.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> >
> > > (1)
> > > - *M* io/module_wrt_grid_comp.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> >
> > > (7)
> > > - *M* module_fcst_grid_comp.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> >
> > > (42)
> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > <
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> >
> > > (109)
> > >
> > > Patch Links:
> > >
> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <#1>, or unsubscribe
> > > <
> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> >
> > > .
> > > Triage notifications on the go with GitHub Mobile for iOS
> > > <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android
> > > <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #1 (comment)>,
> or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> >.
> > Triage notifications on the go with GitHub Mobile for iOS <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
Thanks for letting me know, I was about to start working on the mraerosol branch.
Which lines of code are you talking about when you refer to "why you move merra2_aerosol_aware to the beginning of the code before any initialization" ?
… On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
Dom,
Never mind. I have just found that merra2_thompson of fv3atm is more
up_to_date with your modifications. I have also bring mraerosl of
ufs_weather_model up_to_date and the code has passed compilation and
waiting for the regression test for merra2_thompson in
/scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
The other change is that I treat merra2_aerosol_aware as parallel to
is_aerosol aware in mp_thompson.F90. I do not understand why you move
merra2_aerosol_aware to the beginning of the code before any
initialization.
Anning
On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
> HI, Dom:
>
> my branch for fv3atm is mraerosol too. merra2_thompson is the old version,
> out of date. Could you correct it?
>
>
> On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> wrote:
>
>> Yes, your branch that you gave me was merra2_thompson for fv3atm
>>
>> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
>> >
>> >
>> > HI, Dom,
>> >
>> > I merged, but the head of my branch of fv3atm "mraerosol" is still
>> > at d840d47. Am missing something?
>> >
>> >
>> >
>> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
>> > wrote:
>> >
>> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> please
>> review and
>> > > merge if ok. Thanks!
>> > > ------------------------------
>> > > You can view, comment on, or merge this pull request online at:
>> > >
>> > > #1
>> > > Commit Summary
>> > >
>> > > - CCPP framework update and metadata bug fixes (#367)
>> > > <
>> 16a51fc
>> >
>> > > - Fix stochastic physics restart runs, remove rayleigh damping from
>> > > all suite definition files (#371)
>> > > <
>> 862fe80
>> >
>> > > - Updates to use FMS 2021.03 (#374)
>> > > <
>> 2dc03c1
>> >
>> > > - brings in latest release candidate for the FV3 dycore (#377)
>> > > <
>> 7a97256
>> >
>> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
>> > > <
>> 2fe2998
>> >
>> > > - Add a cplocn2atm namelist option to turn on/off ocean model
>> > > component feedback to FV3ATM (#376)
>> > > <
>> 967b84b
>> >
>> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3 files with
>> > > fms.2021.03, IAU bug fix for restart files (#379)
>> > > <
>> e5dfdd5
>> >
>> > > - Cleanup CCPP cmake build (#383)
>> > > <
>> 85c2648
>> >
>> > > - establish branch mraerosol
>> > > <
>> 53f3c0d
>> >
>> > > - cmake in the FV3 dycore (#389)
>> > > <
>> 026138b
>> >
>> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite file
>> (#391)
>> > > <
>> d77f748
>> >
>> > > - update ccpp with decomposition fix (#397)
>> > > <
>> 06e9b35
>> >
>> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from CODEOWNERS
>> > > (#402)
>> > > <
>> 931f8a3
>> >
>> > > - updates associated with CA restart and PE decomposition bugs (#396)
>> > > <
>> 376d374
>> >
>> > > - fix the output file name and diag time (#404)
>> > > <
>> 799b157
>> >
>> > > - Convert real(kind_phys) vegetation, slope and soil type arrays into
>> > > integer arrays without affecting input/output files (#388)
>> > > <
>> b811a6c
>> >
>> > > - Properly import coupling fields when running with separate run
>> > > phases (#406)
>> > > <
>> 95ff1ca
>> >
>> > > - Add consistency check for Thompson aerosol options to
>> > > GFS_typedefs.F90
>> > > <
>> 2d50c61
>> >
>> > > - Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into
>> > > HEAD
>> > > <
>> b79caf4
>> >
>> > > - Revert change to .gitmodules and update submodule pointer for
>> > > ccpp-physics
>> > > <
>> cfc57d0
>> >
>> > >
>> > > File Changes
>> > >
>> > > - *M* .gitignore
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
>> >
>> > > (10)
>> > > - *M* .gitmodules
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
>> >
>> > > (20)
>> > > - *M* CMakeLists.txt
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
>> >
>> > > (109)
>> > > - *M* atmos_cubed_sphere
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
>> >
>> > > (2)
>> > > - *M* atmos_model.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
>> >
>> > > (51)
>> > > - *M* ccpp/CMakeLists.txt
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
>> >
>> > > (31)
>> > > - *M* ccpp/data/GFS_typedefs.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
>> >
>> > > (572)
>> > > - *M* ccpp/data/GFS_typedefs.meta
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
>> >
>> > > (114)
>> > > - *M* ccpp/driver/GFS_diagnostics.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
>> >
>> > > (32)
>> > > - *M* ccpp/framework
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
>> >
>> > > (2)
>> > > - *M* ccpp/physics
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
>> >
>> > > (2)
>> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
>> >
>> > > (88)
>> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
>> >
>> > > (90)
>> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
>> >
>> > > (88)
>> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
>> >
>> > > (93)
>> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
>> >
>> > > (11)
>> > > - *M* cpl/module_block_data.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
>> >
>> > > (35)
>> > > - *M* fv3_cap.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
>> >
>> > > (73)
>> > > - *M* io/FV3GFS_io.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
>> >
>> > > (881)
>> > > - *M* io/module_fv3_io_def.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
>> >
>> > > (1)
>> > > - *M* io/module_wrt_grid_comp.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
>> >
>> > > (7)
>> > > - *M* module_fcst_grid_comp.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
>> >
>> > > (42)
>> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
>> > > <
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
>> >
>> > > (109)
>> > >
>> > > Patch Links:
>> > >
>> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
>> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
>> > >
>> > > —
>> > > You are receiving this because you were mentioned.
>> > > Reply to this email directly, view it on GitHub
>> > > <#1>, or unsubscribe
>> > > <
>> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
>> >
>> > > .
>> > > Triage notifications on the go with GitHub Mobile for iOS
>> > > <
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> >
>> > > or Android
>> > > <
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> >.
>> > >
>> > >
>> > —
>> > You are receiving this because you authored the thread.
>> > Reply to this email directly, view it on GitHub <
>> #1 (comment)>,
>> or unsubscribe <
>> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
>> >.
>> > Triage notifications on the go with GitHub Mobile for iOS <
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android <
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>> >
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#1 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Dom,
it is line 157-159 in mp_thompson.F90. I have moved them to line 217-218
at /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
The regression test has an error at line 174 of mp_thompson.F90. Something
is wrong with passing nwfa. The regression test dir
is /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
Where are the cap files now? it seems that the compilation automatically
deletes the cap files.
On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
wrote:
… Thanks for letting me know, I was about to start working on the mraerosol
branch.
Which lines of code are you talking about when you refer to "why you move
merra2_aerosol_aware to the beginning of the code before any
initialization" ?
> On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
>
>
> Dom,
>
> Never mind. I have just found that merra2_thompson of fv3atm is more
> up_to_date with your modifications. I have also bring mraerosl of
> ufs_weather_model up_to_date and the code has passed compilation and
> waiting for the regression test for merra2_thompson in
> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
>
> The other change is that I treat merra2_aerosol_aware as parallel to
> is_aerosol aware in mp_thompson.F90. I do not understand why you move
> merra2_aerosol_aware to the beginning of the code before any
> initialization.
>
> Anning
>
>
> On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> ***@***.***> wrote:
>
> > HI, Dom:
> >
> > my branch for fv3atm is mraerosol too. merra2_thompson is the old
version,
> > out of date. Could you correct it?
> >
> >
> > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > wrote:
> >
> >> Yes, your branch that you gave me was merra2_thompson for fv3atm
> >>
> >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> >> >
> >> >
> >> > HI, Dom,
> >> >
> >> > I merged, but the head of my branch of fv3atm "mraerosol" is still
> >> > at d840d47. Am missing something?
> >> >
> >> >
> >> >
> >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> >> > wrote:
> >> >
> >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> please
> >> review and
> >> > > merge if ok. Thanks!
> >> > > ------------------------------
> >> > > You can view, comment on, or merge this pull request online at:
> >> > >
> >> > > #1
> >> > > Commit Summary
> >> > >
> >> > > - CCPP framework update and metadata bug fixes (#367)
> >> > > <
> >>
16a51fc
> >> >
> >> > > - Fix stochastic physics restart runs, remove rayleigh damping
from
> >> > > all suite definition files (#371)
> >> > > <
> >>
862fe80
> >> >
> >> > > - Updates to use FMS 2021.03 (#374)
> >> > > <
> >>
2dc03c1
> >> >
> >> > > - brings in latest release candidate for the FV3 dycore (#377)
> >> > > <
> >>
7a97256
> >> >
> >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> >> > > <
> >>
2fe2998
> >> >
> >> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> >> > > component feedback to FV3ATM (#376)
> >> > > <
> >>
967b84b
> >> >
> >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3 files
with
> >> > > fms.2021.03, IAU bug fix for restart files (#379)
> >> > > <
> >>
e5dfdd5
> >> >
> >> > > - Cleanup CCPP cmake build (#383)
> >> > > <
> >>
85c2648
> >> >
> >> > > - establish branch mraerosol
> >> > > <
> >>
53f3c0d
> >> >
> >> > > - cmake in the FV3 dycore (#389)
> >> > > <
> >>
026138b
> >> >
> >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite file
> >> (#391)
> >> > > <
> >>
d77f748
> >> >
> >> > > - update ccpp with decomposition fix (#397)
> >> > > <
> >>
06e9b35
> >> >
> >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
CODEOWNERS
> >> > > (#402)
> >> > > <
> >>
931f8a3
> >> >
> >> > > - updates associated with CA restart and PE decomposition bugs
(#396)
> >> > > <
> >>
376d374
> >> >
> >> > > - fix the output file name and diag time (#404)
> >> > > <
> >>
799b157
> >> >
> >> > > - Convert real(kind_phys) vegetation, slope and soil type arrays
into
> >> > > integer arrays without affecting input/output files (#388)
> >> > > <
> >>
b811a6c
> >> >
> >> > > - Properly import coupling fields when running with separate run
> >> > > phases (#406)
> >> > > <
> >>
95ff1ca
> >> >
> >> > > - Add consistency check for Thompson aerosol options to
> >> > > GFS_typedefs.F90
> >> > > <
> >>
2d50c61
> >> >
> >> > > - Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm
into
> >> > > HEAD
> >> > > <
> >>
b79caf4
> >> >
> >> > > - Revert change to .gitmodules and update submodule pointer for
> >> > > ccpp-physics
> >> > > <
> >>
cfc57d0
> >> >
> >> > >
> >> > > File Changes
> >> > >
> >> > > - *M* .gitignore
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> >> >
> >> > > (10)
> >> > > - *M* .gitmodules
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> >> >
> >> > > (20)
> >> > > - *M* CMakeLists.txt
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> >> >
> >> > > (109)
> >> > > - *M* atmos_cubed_sphere
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> >> >
> >> > > (2)
> >> > > - *M* atmos_model.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> >> >
> >> > > (51)
> >> > > - *M* ccpp/CMakeLists.txt
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> >> >
> >> > > (31)
> >> > > - *M* ccpp/data/GFS_typedefs.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> >> >
> >> > > (572)
> >> > > - *M* ccpp/data/GFS_typedefs.meta
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> >> >
> >> > > (114)
> >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> >> >
> >> > > (32)
> >> > > - *M* ccpp/framework
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> >> >
> >> > > (2)
> >> > > - *M* ccpp/physics
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> >> >
> >> > > (2)
> >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> >> >
> >> > > (88)
> >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> >> >
> >> > > (90)
> >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> >> >
> >> > > (88)
> >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> >> >
> >> > > (93)
> >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> >> >
> >> > > (11)
> >> > > - *M* cpl/module_block_data.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> >> >
> >> > > (35)
> >> > > - *M* fv3_cap.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> >> >
> >> > > (73)
> >> > > - *M* io/FV3GFS_io.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> >> >
> >> > > (881)
> >> > > - *M* io/module_fv3_io_def.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> >> >
> >> > > (1)
> >> > > - *M* io/module_wrt_grid_comp.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> >> >
> >> > > (7)
> >> > > - *M* module_fcst_grid_comp.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> >> >
> >> > > (42)
> >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> >> > > <
> >>
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> >> >
> >> > > (109)
> >> > >
> >> > > Patch Links:
> >> > >
> >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> >> > >
> >> > > —
> >> > > You are receiving this because you were mentioned.
> >> > > Reply to this email directly, view it on GitHub
> >> > > <#1>, or
unsubscribe
> >> > > <
> >>
https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> >> >
> >> > > .
> >> > > Triage notifications on the go with GitHub Mobile for iOS
> >> > > <
> >>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >> >
> >> > > or Android
> >> > > <
> >>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >> >.
> >> > >
> >> > >
> >> > —
> >> > You are receiving this because you authored the thread.
> >> > Reply to this email directly, view it on GitHub <
> >>
#1 (comment)>,
> >> or unsubscribe <
> >>
https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> >> >.
> >> > Triage notifications on the go with GitHub Mobile for iOS <
> >>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> >> or Android <
> >>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >>
> >> >
> >>
> >> —
> >> You are receiving this because you were mentioned.
> >> Reply to this email directly, view it on GitHub
> >> <
#1 (comment)>,
> >> or unsubscribe
> >> <
https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
>
> >> .
> >> Triage notifications on the go with GitHub Mobile for iOS
> >> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> >> or Android
> >> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >>
> >>
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <
#1 (comment)>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
>.
> Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Your logic is incorrect, because nwfa and nifa will not be converted from moist to dry mixing rattios. That's why I moved the logic up to before the "if(convert_dry_rho)" block.
And is_aerosol_aware and merra2_aerosol_aware should be mutually exclusive, only one of them can be true at any given time. That's how you wrote the code inside module_mp_thompson.F90 and that's what makes sense.
… On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
Dom,
it is line 157-159 in mp_thompson.F90. I have moved them to line 217-218
at /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
The regression test has an error at line 174 of mp_thompson.F90. Something
is wrong with passing nwfa. The regression test dir
is /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
Where are the cap files now? it seems that the compilation automatically
deletes the cap files.
On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
wrote:
> Thanks for letting me know, I was about to start working on the mraerosol
> branch.
>
> Which lines of code are you talking about when you refer to "why you move
> merra2_aerosol_aware to the beginning of the code before any
> initialization" ?
>
> > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> >
> >
> > Dom,
> >
> > Never mind. I have just found that merra2_thompson of fv3atm is more
> > up_to_date with your modifications. I have also bring mraerosl of
> > ufs_weather_model up_to_date and the code has passed compilation and
> > waiting for the regression test for merra2_thompson in
> > /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> >
> > The other change is that I treat merra2_aerosol_aware as parallel to
> > is_aerosol aware in mp_thompson.F90. I do not understand why you move
> > merra2_aerosol_aware to the beginning of the code before any
> > initialization.
> >
> > Anning
> >
> >
> > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > ***@***.***> wrote:
> >
> > > HI, Dom:
> > >
> > > my branch for fv3atm is mraerosol too. merra2_thompson is the old
> version,
> > > out of date. Could you correct it?
> > >
> > >
> > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > wrote:
> > >
> > >> Yes, your branch that you gave me was merra2_thompson for fv3atm
> > >>
> > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> > >> >
> > >> >
> > >> > HI, Dom,
> > >> >
> > >> > I merged, but the head of my branch of fv3atm "mraerosol" is still
> > >> > at d840d47. Am missing something?
> > >> >
> > >> >
> > >> >
> > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > >> > wrote:
> > >> >
> > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> please
> > >> review and
> > >> > > merge if ok. Thanks!
> > >> > > ------------------------------
> > >> > > You can view, comment on, or merge this pull request online at:
> > >> > >
> > >> > > #1
> > >> > > Commit Summary
> > >> > >
> > >> > > - CCPP framework update and metadata bug fixes (#367)
> > >> > > <
> > >>
> 16a51fc
> > >> >
> > >> > > - Fix stochastic physics restart runs, remove rayleigh damping
> from
> > >> > > all suite definition files (#371)
> > >> > > <
> > >>
> 862fe80
> > >> >
> > >> > > - Updates to use FMS 2021.03 (#374)
> > >> > > <
> > >>
> 2dc03c1
> > >> >
> > >> > > - brings in latest release candidate for the FV3 dycore (#377)
> > >> > > <
> > >>
> 7a97256
> > >> >
> > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > >> > > <
> > >>
> 2fe2998
> > >> >
> > >> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> > >> > > component feedback to FV3ATM (#376)
> > >> > > <
> > >>
> 967b84b
> > >> >
> > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3 files
> with
> > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > >> > > <
> > >>
> e5dfdd5
> > >> >
> > >> > > - Cleanup CCPP cmake build (#383)
> > >> > > <
> > >>
> 85c2648
> > >> >
> > >> > > - establish branch mraerosol
> > >> > > <
> > >>
> 53f3c0d
> > >> >
> > >> > > - cmake in the FV3 dycore (#389)
> > >> > > <
> > >>
> 026138b
> > >> >
> > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite file
> > >> (#391)
> > >> > > <
> > >>
> d77f748
> > >> >
> > >> > > - update ccpp with decomposition fix (#397)
> > >> > > <
> > >>
> 06e9b35
> > >> >
> > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
> CODEOWNERS
> > >> > > (#402)
> > >> > > <
> > >>
> 931f8a3
> > >> >
> > >> > > - updates associated with CA restart and PE decomposition bugs
> (#396)
> > >> > > <
> > >>
> 376d374
> > >> >
> > >> > > - fix the output file name and diag time (#404)
> > >> > > <
> > >>
> 799b157
> > >> >
> > >> > > - Convert real(kind_phys) vegetation, slope and soil type arrays
> into
> > >> > > integer arrays without affecting input/output files (#388)
> > >> > > <
> > >>
> b811a6c
> > >> >
> > >> > > - Properly import coupling fields when running with separate run
> > >> > > phases (#406)
> > >> > > <
> > >>
> 95ff1ca
> > >> >
> > >> > > - Add consistency check for Thompson aerosol options to
> > >> > > GFS_typedefs.F90
> > >> > > <
> > >>
> 2d50c61
> > >> >
> > >> > > - Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm
> into
> > >> > > HEAD
> > >> > > <
> > >>
> b79caf4
> > >> >
> > >> > > - Revert change to .gitmodules and update submodule pointer for
> > >> > > ccpp-physics
> > >> > > <
> > >>
> cfc57d0
> > >> >
> > >> > >
> > >> > > File Changes
> > >> > >
> > >> > > - *M* .gitignore
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > >> >
> > >> > > (10)
> > >> > > - *M* .gitmodules
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > >> >
> > >> > > (20)
> > >> > > - *M* CMakeLists.txt
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > >> >
> > >> > > (109)
> > >> > > - *M* atmos_cubed_sphere
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > >> >
> > >> > > (2)
> > >> > > - *M* atmos_model.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > >> >
> > >> > > (51)
> > >> > > - *M* ccpp/CMakeLists.txt
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > >> >
> > >> > > (31)
> > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > >> >
> > >> > > (572)
> > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > >> >
> > >> > > (114)
> > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > >> >
> > >> > > (32)
> > >> > > - *M* ccpp/framework
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > >> >
> > >> > > (2)
> > >> > > - *M* ccpp/physics
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > >> >
> > >> > > (2)
> > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > >> >
> > >> > > (88)
> > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > >> >
> > >> > > (90)
> > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > >> >
> > >> > > (88)
> > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > >> >
> > >> > > (93)
> > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > >> >
> > >> > > (11)
> > >> > > - *M* cpl/module_block_data.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > >> >
> > >> > > (35)
> > >> > > - *M* fv3_cap.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > >> >
> > >> > > (73)
> > >> > > - *M* io/FV3GFS_io.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > >> >
> > >> > > (881)
> > >> > > - *M* io/module_fv3_io_def.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > >> >
> > >> > > (1)
> > >> > > - *M* io/module_wrt_grid_comp.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > >> >
> > >> > > (7)
> > >> > > - *M* module_fcst_grid_comp.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > >> >
> > >> > > (42)
> > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > >> > > <
> > >>
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > >> >
> > >> > > (109)
> > >> > >
> > >> > > Patch Links:
> > >> > >
> > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > >> > >
> > >> > > —
> > >> > > You are receiving this because you were mentioned.
> > >> > > Reply to this email directly, view it on GitHub
> > >> > > <#1>, or
> unsubscribe
> > >> > > <
> > >>
> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > >> >
> > >> > > .
> > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > >> > > <
> > >>
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >> >
> > >> > > or Android
> > >> > > <
> > >>
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >> >.
> > >> > >
> > >> > >
> > >> > —
> > >> > You are receiving this because you authored the thread.
> > >> > Reply to this email directly, view it on GitHub <
> > >>
> #1 (comment)>,
> > >> or unsubscribe <
> > >>
> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > >> >.
> > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > >>
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > >> or Android <
> > >>
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >>
> > >> >
> > >>
> > >> —
> > >> You are receiving this because you were mentioned.
> > >> Reply to this email directly, view it on GitHub
> > >> <
> #1 (comment)>,
> > >> or unsubscribe
> > >> <
> https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> >
> > >> .
> > >> Triage notifications on the go with GitHub Mobile for iOS
> > >> <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > >> or Android
> > >> <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >>
> > >>
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #1 (comment)>,
> or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> >.
> > Triage notifications on the go with GitHub Mobile for iOS <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Dom:
I do not think My logic has any problem. My code is really exclusive for
merra2_aerosol_aware and is_aerosol_aware as below:
if (is_aerosol_aware) then
...
else if (merra2_aerosol_aware) then
...
else
...
end if
Your changes:
if (merra2_aerosol_aware) then
...
end if
if (is_aerosol_aware) then
...
else
...
end if
If both merra_aerosol_aware and is_aerosol_aware are true, my code will be
called only once, your code will be called twice and what has been done in
merra2_aerosol_aware block will be overwritten by is_aerosol_aware block.
Anyhow, Do you have any idea on how to fix my regression tests?
Anning
On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
wrote:
… Your logic is incorrect, because nwfa and nifa will not be converted from
moist to dry mixing rattios. That's why I moved the logic up to before the
"if(convert_dry_rho)" block.
And is_aerosol_aware and merra2_aerosol_aware should be mutually
exclusive, only one of them can be true at any given time. That's how you
wrote the code inside module_mp_thompson.F90 and that's what makes sense.
> On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
>
>
> Dom,
> it is line 157-159 in mp_thompson.F90. I have moved them to line 217-218
> at
/scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
>
> The regression test has an error at line 174 of mp_thompson.F90.
Something
> is wrong with passing nwfa. The regression test dir
> is /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
>
> Where are the cap files now? it seems that the compilation automatically
> deletes the cap files.
>
>
> On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
> wrote:
>
> > Thanks for letting me know, I was about to start working on the
mraerosol
> > branch.
> >
> > Which lines of code are you talking about when you refer to "why you
move
> > merra2_aerosol_aware to the beginning of the code before any
> > initialization" ?
> >
> > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> > >
> > >
> > > Dom,
> > >
> > > Never mind. I have just found that merra2_thompson of fv3atm is more
> > > up_to_date with your modifications. I have also bring mraerosl of
> > > ufs_weather_model up_to_date and the code has passed compilation and
> > > waiting for the regression test for merra2_thompson in
> > > /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> > >
> > > The other change is that I treat merra2_aerosol_aware as parallel to
> > > is_aerosol aware in mp_thompson.F90. I do not understand why you move
> > > merra2_aerosol_aware to the beginning of the code before any
> > > initialization.
> > >
> > > Anning
> > >
> > >
> > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > > ***@***.***> wrote:
> > >
> > > > HI, Dom:
> > > >
> > > > my branch for fv3atm is mraerosol too. merra2_thompson is the old
> > version,
> > > > out of date. Could you correct it?
> > > >
> > > >
> > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > > wrote:
> > > >
> > > >> Yes, your branch that you gave me was merra2_thompson for fv3atm
> > > >>
> > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> > > >> >
> > > >> >
> > > >> > HI, Dom,
> > > >> >
> > > >> > I merged, but the head of my branch of fv3atm "mraerosol" is
still
> > > >> > at d840d47. Am missing something?
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > > >> > wrote:
> > > >> >
> > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
please
> > > >> review and
> > > >> > > merge if ok. Thanks!
> > > >> > > ------------------------------
> > > >> > > You can view, comment on, or merge this pull request online
at:
> > > >> > >
> > > >> > > #1
> > > >> > > Commit Summary
> > > >> > >
> > > >> > > - CCPP framework update and metadata bug fixes (#367)
> > > >> > > <
> > > >>
> >
16a51fc
> > > >> >
> > > >> > > - Fix stochastic physics restart runs, remove rayleigh damping
> > from
> > > >> > > all suite definition files (#371)
> > > >> > > <
> > > >>
> >
862fe80
> > > >> >
> > > >> > > - Updates to use FMS 2021.03 (#374)
> > > >> > > <
> > > >>
> >
2dc03c1
> > > >> >
> > > >> > > - brings in latest release candidate for the FV3 dycore (#377)
> > > >> > > <
> > > >>
> >
7a97256
> > > >> >
> > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > >> > > <
> > > >>
> >
2fe2998
> > > >> >
> > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> > > >> > > component feedback to FV3ATM (#376)
> > > >> > > <
> > > >>
> >
967b84b
> > > >> >
> > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
files
> > with
> > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > >> > > <
> > > >>
> >
e5dfdd5
> > > >> >
> > > >> > > - Cleanup CCPP cmake build (#383)
> > > >> > > <
> > > >>
> >
85c2648
> > > >> >
> > > >> > > - establish branch mraerosol
> > > >> > > <
> > > >>
> >
53f3c0d
> > > >> >
> > > >> > > - cmake in the FV3 dycore (#389)
> > > >> > > <
> > > >>
> >
026138b
> > > >> >
> > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite
file
> > > >> (#391)
> > > >> > > <
> > > >>
> >
d77f748
> > > >> >
> > > >> > > - update ccpp with decomposition fix (#397)
> > > >> > > <
> > > >>
> >
06e9b35
> > > >> >
> > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
> > CODEOWNERS
> > > >> > > (#402)
> > > >> > > <
> > > >>
> >
931f8a3
> > > >> >
> > > >> > > - updates associated with CA restart and PE decomposition bugs
> > (#396)
> > > >> > > <
> > > >>
> >
376d374
> > > >> >
> > > >> > > - fix the output file name and diag time (#404)
> > > >> > > <
> > > >>
> >
799b157
> > > >> >
> > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
arrays
> > into
> > > >> > > integer arrays without affecting input/output files (#388)
> > > >> > > <
> > > >>
> >
b811a6c
> > > >> >
> > > >> > > - Properly import coupling fields when running with separate
run
> > > >> > > phases (#406)
> > > >> > > <
> > > >>
> >
95ff1ca
> > > >> >
> > > >> > > - Add consistency check for Thompson aerosol options to
> > > >> > > GFS_typedefs.F90
> > > >> > > <
> > > >>
> >
2d50c61
> > > >> >
> > > >> > > - Merge branch 'develop' of
https://github.com/NOAA-EMC/fv3atm
> > into
> > > >> > > HEAD
> > > >> > > <
> > > >>
> >
b79caf4
> > > >> >
> > > >> > > - Revert change to .gitmodules and update submodule pointer
for
> > > >> > > ccpp-physics
> > > >> > > <
> > > >>
> >
cfc57d0
> > > >> >
> > > >> > >
> > > >> > > File Changes
> > > >> > >
> > > >> > > - *M* .gitignore
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > > >> >
> > > >> > > (10)
> > > >> > > - *M* .gitmodules
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > > >> >
> > > >> > > (20)
> > > >> > > - *M* CMakeLists.txt
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > > >> >
> > > >> > > (109)
> > > >> > > - *M* atmos_cubed_sphere
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > > >> >
> > > >> > > (2)
> > > >> > > - *M* atmos_model.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > > >> >
> > > >> > > (51)
> > > >> > > - *M* ccpp/CMakeLists.txt
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > > >> >
> > > >> > > (31)
> > > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > > >> >
> > > >> > > (572)
> > > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > > >> >
> > > >> > > (114)
> > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > > >> >
> > > >> > > (32)
> > > >> > > - *M* ccpp/framework
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > > >> >
> > > >> > > (2)
> > > >> > > - *M* ccpp/physics
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > > >> >
> > > >> > > (2)
> > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > > >> >
> > > >> > > (88)
> > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > > >> >
> > > >> > > (90)
> > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > > >> >
> > > >> > > (88)
> > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > > >> >
> > > >> > > (93)
> > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > > >> >
> > > >> > > (11)
> > > >> > > - *M* cpl/module_block_data.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > > >> >
> > > >> > > (35)
> > > >> > > - *M* fv3_cap.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > > >> >
> > > >> > > (73)
> > > >> > > - *M* io/FV3GFS_io.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > > >> >
> > > >> > > (881)
> > > >> > > - *M* io/module_fv3_io_def.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > > >> >
> > > >> > > (1)
> > > >> > > - *M* io/module_wrt_grid_comp.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > > >> >
> > > >> > > (7)
> > > >> > > - *M* module_fcst_grid_comp.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > > >> >
> > > >> > > (42)
> > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > >> > > <
> > > >>
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > > >> >
> > > >> > > (109)
> > > >> > >
> > > >> > > Patch Links:
> > > >> > >
> > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > > >> > >
> > > >> > > —
> > > >> > > You are receiving this because you were mentioned.
> > > >> > > Reply to this email directly, view it on GitHub
> > > >> > > <#1>, or
> > unsubscribe
> > > >> > > <
> > > >>
> >
https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > > >> >
> > > >> > > .
> > > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > > >> > > <
> > > >>
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >> >
> > > >> > > or Android
> > > >> > > <
> > > >>
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >> >.
> > > >> > >
> > > >> > >
> > > >> > —
> > > >> > You are receiving this because you authored the thread.
> > > >> > Reply to this email directly, view it on GitHub <
> > > >>
> >
#1 (comment)>,
> > > >> or unsubscribe <
> > > >>
> >
https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > > >> >.
> > > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > > >>
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >
> > > >> or Android <
> > > >>
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >.
> > > >>
> > > >> >
> > > >>
> > > >> —
> > > >> You are receiving this because you were mentioned.
> > > >> Reply to this email directly, view it on GitHub
> > > >> <
> >
#1 (comment)>,
> > > >> or unsubscribe
> > > >> <
> >
https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> > >
> > > >> .
> > > >> Triage notifications on the go with GitHub Mobile for iOS
> > > >> <
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >
> > > >> or Android
> > > >> <
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >.
> > > >>
> > > >>
> > > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub <
> >
#1 (comment)>,
> > or unsubscribe <
> >
https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> > >.
> > > Triage notifications on the go with GitHub Mobile for iOS <
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> > or Android <
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#1 (comment)>,
> > or unsubscribe
> > <
https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
>
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> > or Android
> > <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <
#1 (comment)>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
>.
> Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Your logic has a problem because you are not converting from moist to dry mixing ratios/number concentrations (but you are converting back from dry to moist). I agree that your code doesn't have a problem with is_aerosol_aware vs merra2_aerosol_aware.
And if you look carefully in lines 127-131 in mp_thompson.F90, then you will see that my logic is just as fine, too, because is_aerosol_aware and merra2_aerosol_aware cannot be true at the same time.
… On Oct 8, 2021, at 10:42 AM, AnningCheng-NOAA ***@***.***> wrote:
Dom:
I do not think My logic has any problem. My code is really exclusive for
merra2_aerosol_aware and is_aerosol_aware as below:
if (is_aerosol_aware) then
...
else if (merra2_aerosol_aware) then
...
else
...
end if
Your changes:
if (merra2_aerosol_aware) then
...
end if
if (is_aerosol_aware) then
...
else
...
end if
If both merra_aerosol_aware and is_aerosol_aware are true, my code will be
called only once, your code will be called twice and what has been done in
merra2_aerosol_aware block will be overwritten by is_aerosol_aware block.
Anyhow, Do you have any idea on how to fix my regression tests?
Anning
On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
wrote:
> Your logic is incorrect, because nwfa and nifa will not be converted from
> moist to dry mixing rattios. That's why I moved the logic up to before the
> "if(convert_dry_rho)" block.
>
> And is_aerosol_aware and merra2_aerosol_aware should be mutually
> exclusive, only one of them can be true at any given time. That's how you
> wrote the code inside module_mp_thompson.F90 and that's what makes sense.
>
> > On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
> >
> >
> > Dom,
> > it is line 157-159 in mp_thompson.F90. I have moved them to line 217-218
> > at
> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
> >
> > The regression test has an error at line 174 of mp_thompson.F90.
> Something
> > is wrong with passing nwfa. The regression test dir
> > is /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
> >
> > Where are the cap files now? it seems that the compilation automatically
> > deletes the cap files.
> >
> >
> > On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
> > wrote:
> >
> > > Thanks for letting me know, I was about to start working on the
> mraerosol
> > > branch.
> > >
> > > Which lines of code are you talking about when you refer to "why you
> move
> > > merra2_aerosol_aware to the beginning of the code before any
> > > initialization" ?
> > >
> > > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> > > >
> > > >
> > > > Dom,
> > > >
> > > > Never mind. I have just found that merra2_thompson of fv3atm is more
> > > > up_to_date with your modifications. I have also bring mraerosl of
> > > > ufs_weather_model up_to_date and the code has passed compilation and
> > > > waiting for the regression test for merra2_thompson in
> > > > /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> > > >
> > > > The other change is that I treat merra2_aerosol_aware as parallel to
> > > > is_aerosol aware in mp_thompson.F90. I do not understand why you move
> > > > merra2_aerosol_aware to the beginning of the code before any
> > > > initialization.
> > > >
> > > > Anning
> > > >
> > > >
> > > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > > > ***@***.***> wrote:
> > > >
> > > > > HI, Dom:
> > > > >
> > > > > my branch for fv3atm is mraerosol too. merra2_thompson is the old
> > > version,
> > > > > out of date. Could you correct it?
> > > > >
> > > > >
> > > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > > > wrote:
> > > > >
> > > > >> Yes, your branch that you gave me was merra2_thompson for fv3atm
> > > > >>
> > > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> > > > >> >
> > > > >> >
> > > > >> > HI, Dom,
> > > > >> >
> > > > >> > I merged, but the head of my branch of fv3atm "mraerosol" is
> still
> > > > >> > at d840d47. Am missing something?
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > > > >> > wrote:
> > > > >> >
> > > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
> please
> > > > >> review and
> > > > >> > > merge if ok. Thanks!
> > > > >> > > ------------------------------
> > > > >> > > You can view, comment on, or merge this pull request online
> at:
> > > > >> > >
> > > > >> > > #1
> > > > >> > > Commit Summary
> > > > >> > >
> > > > >> > > - CCPP framework update and metadata bug fixes (#367)
> > > > >> > > <
> > > > >>
> > >
> 16a51fc
> > > > >> >
> > > > >> > > - Fix stochastic physics restart runs, remove rayleigh damping
> > > from
> > > > >> > > all suite definition files (#371)
> > > > >> > > <
> > > > >>
> > >
> 862fe80
> > > > >> >
> > > > >> > > - Updates to use FMS 2021.03 (#374)
> > > > >> > > <
> > > > >>
> > >
> 2dc03c1
> > > > >> >
> > > > >> > > - brings in latest release candidate for the FV3 dycore (#377)
> > > > >> > > <
> > > > >>
> > >
> 7a97256
> > > > >> >
> > > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > > >> > > <
> > > > >>
> > >
> 2fe2998
> > > > >> >
> > > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> > > > >> > > component feedback to FV3ATM (#376)
> > > > >> > > <
> > > > >>
> > >
> 967b84b
> > > > >> >
> > > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
> files
> > > with
> > > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > > >> > > <
> > > > >>
> > >
> e5dfdd5
> > > > >> >
> > > > >> > > - Cleanup CCPP cmake build (#383)
> > > > >> > > <
> > > > >>
> > >
> 85c2648
> > > > >> >
> > > > >> > > - establish branch mraerosol
> > > > >> > > <
> > > > >>
> > >
> 53f3c0d
> > > > >> >
> > > > >> > > - cmake in the FV3 dycore (#389)
> > > > >> > > <
> > > > >>
> > >
> 026138b
> > > > >> >
> > > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite
> file
> > > > >> (#391)
> > > > >> > > <
> > > > >>
> > >
> d77f748
> > > > >> >
> > > > >> > > - update ccpp with decomposition fix (#397)
> > > > >> > > <
> > > > >>
> > >
> 06e9b35
> > > > >> >
> > > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
> > > CODEOWNERS
> > > > >> > > (#402)
> > > > >> > > <
> > > > >>
> > >
> 931f8a3
> > > > >> >
> > > > >> > > - updates associated with CA restart and PE decomposition bugs
> > > (#396)
> > > > >> > > <
> > > > >>
> > >
> 376d374
> > > > >> >
> > > > >> > > - fix the output file name and diag time (#404)
> > > > >> > > <
> > > > >>
> > >
> 799b157
> > > > >> >
> > > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
> arrays
> > > into
> > > > >> > > integer arrays without affecting input/output files (#388)
> > > > >> > > <
> > > > >>
> > >
> b811a6c
> > > > >> >
> > > > >> > > - Properly import coupling fields when running with separate
> run
> > > > >> > > phases (#406)
> > > > >> > > <
> > > > >>
> > >
> 95ff1ca
> > > > >> >
> > > > >> > > - Add consistency check for Thompson aerosol options to
> > > > >> > > GFS_typedefs.F90
> > > > >> > > <
> > > > >>
> > >
> 2d50c61
> > > > >> >
> > > > >> > > - Merge branch 'develop' of
> https://github.com/NOAA-EMC/fv3atm
> > > into
> > > > >> > > HEAD
> > > > >> > > <
> > > > >>
> > >
> b79caf4
> > > > >> >
> > > > >> > > - Revert change to .gitmodules and update submodule pointer
> for
> > > > >> > > ccpp-physics
> > > > >> > > <
> > > > >>
> > >
> cfc57d0
> > > > >> >
> > > > >> > >
> > > > >> > > File Changes
> > > > >> > >
> > > > >> > > - *M* .gitignore
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > > > >> >
> > > > >> > > (10)
> > > > >> > > - *M* .gitmodules
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > > > >> >
> > > > >> > > (20)
> > > > >> > > - *M* CMakeLists.txt
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > > > >> >
> > > > >> > > (109)
> > > > >> > > - *M* atmos_cubed_sphere
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *M* atmos_model.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > > > >> >
> > > > >> > > (51)
> > > > >> > > - *M* ccpp/CMakeLists.txt
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > > > >> >
> > > > >> > > (31)
> > > > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > > > >> >
> > > > >> > > (572)
> > > > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > > > >> >
> > > > >> > > (114)
> > > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > > > >> >
> > > > >> > > (32)
> > > > >> > > - *M* ccpp/framework
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *M* ccpp/physics
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > > > >> >
> > > > >> > > (88)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > > > >> >
> > > > >> > > (90)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > > > >> >
> > > > >> > > (88)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > > > >> >
> > > > >> > > (93)
> > > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > > > >> >
> > > > >> > > (11)
> > > > >> > > - *M* cpl/module_block_data.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > > > >> >
> > > > >> > > (35)
> > > > >> > > - *M* fv3_cap.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > > > >> >
> > > > >> > > (73)
> > > > >> > > - *M* io/FV3GFS_io.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > > > >> >
> > > > >> > > (881)
> > > > >> > > - *M* io/module_fv3_io_def.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > > > >> >
> > > > >> > > (1)
> > > > >> > > - *M* io/module_wrt_grid_comp.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > > > >> >
> > > > >> > > (7)
> > > > >> > > - *M* module_fcst_grid_comp.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > > > >> >
> > > > >> > > (42)
> > > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > > > >> >
> > > > >> > > (109)
> > > > >> > >
> > > > >> > > Patch Links:
> > > > >> > >
> > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > > > >> > >
> > > > >> > > —
> > > > >> > > You are receiving this because you were mentioned.
> > > > >> > > Reply to this email directly, view it on GitHub
> > > > >> > > <#1>, or
> > > unsubscribe
> > > > >> > > <
> > > > >>
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > > > >> >
> > > > >> > > .
> > > > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > > > >> > > <
> > > > >>
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > >> >
> > > > >> > > or Android
> > > > >> > > <
> > > > >>
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > >> >.
> > > > >> > >
> > > > >> > >
> > > > >> > —
> > > > >> > You are receiving this because you authored the thread.
> > > > >> > Reply to this email directly, view it on GitHub <
> > > > >>
> > >
> #1 (comment)>,
> > > > >> or unsubscribe <
> > > > >>
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > > > >> >.
> > > > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > > > >>
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > >> or Android <
> > > > >>
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >>
> > > > >> >
> > > > >>
> > > > >> —
> > > > >> You are receiving this because you were mentioned.
> > > > >> Reply to this email directly, view it on GitHub
> > > > >> <
> > >
> #1 (comment)>,
> > > > >> or unsubscribe
> > > > >> <
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> > > >
> > > > >> .
> > > > >> Triage notifications on the go with GitHub Mobile for iOS
> > > > >> <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > >> or Android
> > > > >> <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >>
> > > > >>
> > > > >
> > > > —
> > > > You are receiving this because you authored the thread.
> > > > Reply to this email directly, view it on GitHub <
> > >
> #1 (comment)>,
> > > or unsubscribe <
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> > > >.
> > > > Triage notifications on the go with GitHub Mobile for iOS <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> #1 (comment)>,
> > > or unsubscribe
> > > <
> https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
> >
> > > .
> > > Triage notifications on the go with GitHub Mobile for iOS
> > > <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android
> > > <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #1 (comment)>,
> or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
> >.
> > Triage notifications on the go with GitHub Mobile for iOS <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RKQ4TNJSCWYQ3JP6ZLUF4NQPANCNFSM5FSDNTTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I unfortunately won't have time to look into your test before my leave starts. I will be back Oct 18, hopefully you can figure out what the problem is.
… On Oct 8, 2021, at 10:42 AM, AnningCheng-NOAA ***@***.***> wrote:
Dom:
I do not think My logic has any problem. My code is really exclusive for
merra2_aerosol_aware and is_aerosol_aware as below:
if (is_aerosol_aware) then
...
else if (merra2_aerosol_aware) then
...
else
...
end if
Your changes:
if (merra2_aerosol_aware) then
...
end if
if (is_aerosol_aware) then
...
else
...
end if
If both merra_aerosol_aware and is_aerosol_aware are true, my code will be
called only once, your code will be called twice and what has been done in
merra2_aerosol_aware block will be overwritten by is_aerosol_aware block.
Anyhow, Do you have any idea on how to fix my regression tests?
Anning
On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
wrote:
> Your logic is incorrect, because nwfa and nifa will not be converted from
> moist to dry mixing rattios. That's why I moved the logic up to before the
> "if(convert_dry_rho)" block.
>
> And is_aerosol_aware and merra2_aerosol_aware should be mutually
> exclusive, only one of them can be true at any given time. That's how you
> wrote the code inside module_mp_thompson.F90 and that's what makes sense.
>
> > On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
> >
> >
> > Dom,
> > it is line 157-159 in mp_thompson.F90. I have moved them to line 217-218
> > at
> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
> >
> > The regression test has an error at line 174 of mp_thompson.F90.
> Something
> > is wrong with passing nwfa. The regression test dir
> > is /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
> >
> > Where are the cap files now? it seems that the compilation automatically
> > deletes the cap files.
> >
> >
> > On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
> > wrote:
> >
> > > Thanks for letting me know, I was about to start working on the
> mraerosol
> > > branch.
> > >
> > > Which lines of code are you talking about when you refer to "why you
> move
> > > merra2_aerosol_aware to the beginning of the code before any
> > > initialization" ?
> > >
> > > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> > > >
> > > >
> > > > Dom,
> > > >
> > > > Never mind. I have just found that merra2_thompson of fv3atm is more
> > > > up_to_date with your modifications. I have also bring mraerosl of
> > > > ufs_weather_model up_to_date and the code has passed compilation and
> > > > waiting for the regression test for merra2_thompson in
> > > > /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> > > >
> > > > The other change is that I treat merra2_aerosol_aware as parallel to
> > > > is_aerosol aware in mp_thompson.F90. I do not understand why you move
> > > > merra2_aerosol_aware to the beginning of the code before any
> > > > initialization.
> > > >
> > > > Anning
> > > >
> > > >
> > > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > > > ***@***.***> wrote:
> > > >
> > > > > HI, Dom:
> > > > >
> > > > > my branch for fv3atm is mraerosol too. merra2_thompson is the old
> > > version,
> > > > > out of date. Could you correct it?
> > > > >
> > > > >
> > > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > > > wrote:
> > > > >
> > > > >> Yes, your branch that you gave me was merra2_thompson for fv3atm
> > > > >>
> > > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***> wrote:
> > > > >> >
> > > > >> >
> > > > >> > HI, Dom,
> > > > >> >
> > > > >> > I merged, but the head of my branch of fv3atm "mraerosol" is
> still
> > > > >> > at d840d47. Am missing something?
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > > > >> > wrote:
> > > > >> >
> > > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
> please
> > > > >> review and
> > > > >> > > merge if ok. Thanks!
> > > > >> > > ------------------------------
> > > > >> > > You can view, comment on, or merge this pull request online
> at:
> > > > >> > >
> > > > >> > > #1
> > > > >> > > Commit Summary
> > > > >> > >
> > > > >> > > - CCPP framework update and metadata bug fixes (#367)
> > > > >> > > <
> > > > >>
> > >
> 16a51fc
> > > > >> >
> > > > >> > > - Fix stochastic physics restart runs, remove rayleigh damping
> > > from
> > > > >> > > all suite definition files (#371)
> > > > >> > > <
> > > > >>
> > >
> 862fe80
> > > > >> >
> > > > >> > > - Updates to use FMS 2021.03 (#374)
> > > > >> > > <
> > > > >>
> > >
> 2dc03c1
> > > > >> >
> > > > >> > > - brings in latest release candidate for the FV3 dycore (#377)
> > > > >> > > <
> > > > >>
> > >
> 7a97256
> > > > >> >
> > > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > > >> > > <
> > > > >>
> > >
> 2fe2998
> > > > >> >
> > > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean model
> > > > >> > > component feedback to FV3ATM (#376)
> > > > >> > > <
> > > > >>
> > >
> 967b84b
> > > > >> >
> > > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
> files
> > > with
> > > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > > >> > > <
> > > > >>
> > >
> e5dfdd5
> > > > >> >
> > > > >> > > - Cleanup CCPP cmake build (#383)
> > > > >> > > <
> > > > >>
> > >
> 85c2648
> > > > >> >
> > > > >> > > - establish branch mraerosol
> > > > >> > > <
> > > > >>
> > >
> 53f3c0d
> > > > >> >
> > > > >> > > - cmake in the FV3 dycore (#389)
> > > > >> > > <
> > > > >>
> > >
> 026138b
> > > > >> >
> > > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP suite
> file
> > > > >> (#391)
> > > > >> > > <
> > > > >>
> > >
> d77f748
> > > > >> >
> > > > >> > > - update ccpp with decomposition fix (#397)
> > > > >> > > <
> > > > >>
> > >
> 06e9b35
> > > > >> >
> > > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
> > > CODEOWNERS
> > > > >> > > (#402)
> > > > >> > > <
> > > > >>
> > >
> 931f8a3
> > > > >> >
> > > > >> > > - updates associated with CA restart and PE decomposition bugs
> > > (#396)
> > > > >> > > <
> > > > >>
> > >
> 376d374
> > > > >> >
> > > > >> > > - fix the output file name and diag time (#404)
> > > > >> > > <
> > > > >>
> > >
> 799b157
> > > > >> >
> > > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
> arrays
> > > into
> > > > >> > > integer arrays without affecting input/output files (#388)
> > > > >> > > <
> > > > >>
> > >
> b811a6c
> > > > >> >
> > > > >> > > - Properly import coupling fields when running with separate
> run
> > > > >> > > phases (#406)
> > > > >> > > <
> > > > >>
> > >
> 95ff1ca
> > > > >> >
> > > > >> > > - Add consistency check for Thompson aerosol options to
> > > > >> > > GFS_typedefs.F90
> > > > >> > > <
> > > > >>
> > >
> 2d50c61
> > > > >> >
> > > > >> > > - Merge branch 'develop' of
> https://github.com/NOAA-EMC/fv3atm
> > > into
> > > > >> > > HEAD
> > > > >> > > <
> > > > >>
> > >
> b79caf4
> > > > >> >
> > > > >> > > - Revert change to .gitmodules and update submodule pointer
> for
> > > > >> > > ccpp-physics
> > > > >> > > <
> > > > >>
> > >
> cfc57d0
> > > > >> >
> > > > >> > >
> > > > >> > > File Changes
> > > > >> > >
> > > > >> > > - *M* .gitignore
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > > > >> >
> > > > >> > > (10)
> > > > >> > > - *M* .gitmodules
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > > > >> >
> > > > >> > > (20)
> > > > >> > > - *M* CMakeLists.txt
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > > > >> >
> > > > >> > > (109)
> > > > >> > > - *M* atmos_cubed_sphere
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *M* atmos_model.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > > > >> >
> > > > >> > > (51)
> > > > >> > > - *M* ccpp/CMakeLists.txt
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > > > >> >
> > > > >> > > (31)
> > > > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > > > >> >
> > > > >> > > (572)
> > > > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > > > >> >
> > > > >> > > (114)
> > > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > > > >> >
> > > > >> > > (32)
> > > > >> > > - *M* ccpp/framework
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *M* ccpp/physics
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > > > >> >
> > > > >> > > (2)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > > > >> >
> > > > >> > > (88)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > > > >> >
> > > > >> > > (90)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > > > >> >
> > > > >> > > (88)
> > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > > > >> >
> > > > >> > > (93)
> > > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > > > >> >
> > > > >> > > (11)
> > > > >> > > - *M* cpl/module_block_data.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > > > >> >
> > > > >> > > (35)
> > > > >> > > - *M* fv3_cap.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > > > >> >
> > > > >> > > (73)
> > > > >> > > - *M* io/FV3GFS_io.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > > > >> >
> > > > >> > > (881)
> > > > >> > > - *M* io/module_fv3_io_def.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > > > >> >
> > > > >> > > (1)
> > > > >> > > - *M* io/module_wrt_grid_comp.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > > > >> >
> > > > >> > > (7)
> > > > >> > > - *M* module_fcst_grid_comp.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > > > >> >
> > > > >> > > (42)
> > > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > > >> > > <
> > > > >>
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > > > >> >
> > > > >> > > (109)
> > > > >> > >
> > > > >> > > Patch Links:
> > > > >> > >
> > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > > > >> > >
> > > > >> > > —
> > > > >> > > You are receiving this because you were mentioned.
> > > > >> > > Reply to this email directly, view it on GitHub
> > > > >> > > <#1>, or
> > > unsubscribe
> > > > >> > > <
> > > > >>
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > > > >> >
> > > > >> > > .
> > > > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > > > >> > > <
> > > > >>
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > >> >
> > > > >> > > or Android
> > > > >> > > <
> > > > >>
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > >> >.
> > > > >> > >
> > > > >> > >
> > > > >> > —
> > > > >> > You are receiving this because you authored the thread.
> > > > >> > Reply to this email directly, view it on GitHub <
> > > > >>
> > >
> #1 (comment)>,
> > > > >> or unsubscribe <
> > > > >>
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > > > >> >.
> > > > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > > > >>
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > >> or Android <
> > > > >>
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >>
> > > > >> >
> > > > >>
> > > > >> —
> > > > >> You are receiving this because you were mentioned.
> > > > >> Reply to this email directly, view it on GitHub
> > > > >> <
> > >
> #1 (comment)>,
> > > > >> or unsubscribe
> > > > >> <
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> > > >
> > > > >> .
> > > > >> Triage notifications on the go with GitHub Mobile for iOS
> > > > >> <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > >> or Android
> > > > >> <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >>
> > > > >>
> > > > >
> > > > —
> > > > You are receiving this because you authored the thread.
> > > > Reply to this email directly, view it on GitHub <
> > >
> #1 (comment)>,
> > > or unsubscribe <
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> > > >.
> > > > Triage notifications on the go with GitHub Mobile for iOS <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> #1 (comment)>,
> > > or unsubscribe
> > > <
> https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
> >
> > > .
> > > Triage notifications on the go with GitHub Mobile for iOS
> > > <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android
> > > <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #1 (comment)>,
> or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
> >.
> > Triage notifications on the go with GitHub Mobile for iOS <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RKQ4TNJSCWYQ3JP6ZLUF4NQPANCNFSM5FSDNTTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Dom,
I kind of understand, but nifa and nwfa from merra2 climatology are always
dry. I do not think the necessity to perform such conversion and simply
neglect it.
On Fri, Oct 8, 2021 at 12:47 PM Dom Heinzeller ***@***.***>
wrote:
… Your logic has a problem because you are not converting from moist to dry
mixing ratios/number concentrations (but you are converting back from dry
to moist). I agree that your code doesn't have a problem with
is_aerosol_aware vs merra2_aerosol_aware.
And if you look carefully in lines 127-131 in mp_thompson.F90, then you
will see that my logic is just as fine, too, because is_aerosol_aware and
merra2_aerosol_aware cannot be true at the same time.
> On Oct 8, 2021, at 10:42 AM, AnningCheng-NOAA ***@***.***> wrote:
>
>
> Dom:
>
> I do not think My logic has any problem. My code is really exclusive for
> merra2_aerosol_aware and is_aerosol_aware as below:
> if (is_aerosol_aware) then
> ...
> else if (merra2_aerosol_aware) then
> ...
> else
> ...
> end if
>
> Your changes:
> if (merra2_aerosol_aware) then
> ...
> end if
> if (is_aerosol_aware) then
> ...
> else
> ...
> end if
>
> If both merra_aerosol_aware and is_aerosol_aware are true, my code will
be
> called only once, your code will be called twice and what has been done
in
> merra2_aerosol_aware block will be overwritten by is_aerosol_aware block.
>
> Anyhow, Do you have any idea on how to fix my regression tests?
>
> Anning
>
>
>
>
> On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
> wrote:
>
> > Your logic is incorrect, because nwfa and nifa will not be converted
from
> > moist to dry mixing rattios. That's why I moved the logic up to before
the
> > "if(convert_dry_rho)" block.
> >
> > And is_aerosol_aware and merra2_aerosol_aware should be mutually
> > exclusive, only one of them can be true at any given time. That's how
you
> > wrote the code inside module_mp_thompson.F90 and that's what makes
sense.
> >
> > > On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
> > >
> > >
> > > Dom,
> > > it is line 157-159 in mp_thompson.F90. I have moved them to line
217-218
> > > at
> >
/scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
> > >
> > > The regression test has an error at line 174 of mp_thompson.F90.
> > Something
> > > is wrong with passing nwfa. The regression test dir
> > > is
/scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
> > >
> > > Where are the cap files now? it seems that the compilation
automatically
> > > deletes the cap files.
> > >
> > >
> > > On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
> > > wrote:
> > >
> > > > Thanks for letting me know, I was about to start working on the
> > mraerosol
> > > > branch.
> > > >
> > > > Which lines of code are you talking about when you refer to "why
you
> > move
> > > > merra2_aerosol_aware to the beginning of the code before any
> > > > initialization" ?
> > > >
> > > > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> > > > >
> > > > >
> > > > > Dom,
> > > > >
> > > > > Never mind. I have just found that merra2_thompson of fv3atm is
more
> > > > > up_to_date with your modifications. I have also bring mraerosl of
> > > > > ufs_weather_model up_to_date and the code has passed compilation
and
> > > > > waiting for the regression test for merra2_thompson in
> > > > >
/scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> > > > >
> > > > > The other change is that I treat merra2_aerosol_aware as
parallel to
> > > > > is_aerosol aware in mp_thompson.F90. I do not understand why you
move
> > > > > merra2_aerosol_aware to the beginning of the code before any
> > > > > initialization.
> > > > >
> > > > > Anning
> > > > >
> > > > >
> > > > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > > > > ***@***.***> wrote:
> > > > >
> > > > > > HI, Dom:
> > > > > >
> > > > > > my branch for fv3atm is mraerosol too. merra2_thompson is the
old
> > > > version,
> > > > > > out of date. Could you correct it?
> > > > > >
> > > > > >
> > > > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > > > > wrote:
> > > > > >
> > > > > >> Yes, your branch that you gave me was merra2_thompson for
fv3atm
> > > > > >>
> > > > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***>
wrote:
> > > > > >> >
> > > > > >> >
> > > > > >> > HI, Dom,
> > > > > >> >
> > > > > >> > I merged, but the head of my branch of fv3atm "mraerosol" is
> > still
> > > > > >> > at d840d47. Am missing something?
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > > > > >> > wrote:
> > > > > >> >
> > > > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
> > please
> > > > > >> review and
> > > > > >> > > merge if ok. Thanks!
> > > > > >> > > ------------------------------
> > > > > >> > > You can view, comment on, or merge this pull request
online
> > at:
> > > > > >> > >
> > > > > >> > > #1
> > > > > >> > > Commit Summary
> > > > > >> > >
> > > > > >> > > - CCPP framework update and metadata bug fixes (#367)
> > > > > >> > > <
> > > > > >>
> > > >
> >
16a51fc
> > > > > >> >
> > > > > >> > > - Fix stochastic physics restart runs, remove rayleigh
damping
> > > > from
> > > > > >> > > all suite definition files (#371)
> > > > > >> > > <
> > > > > >>
> > > >
> >
862fe80
> > > > > >> >
> > > > > >> > > - Updates to use FMS 2021.03 (#374)
> > > > > >> > > <
> > > > > >>
> > > >
> >
2dc03c1
> > > > > >> >
> > > > > >> > > - brings in latest release candidate for the FV3 dycore
(#377)
> > > > > >> > > <
> > > > > >>
> > > >
> >
7a97256
> > > > > >> >
> > > > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > > > >> > > <
> > > > > >>
> > > >
> >
2fe2998
> > > > > >> >
> > > > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean
model
> > > > > >> > > component feedback to FV3ATM (#376)
> > > > > >> > > <
> > > > > >>
> > > >
> >
967b84b
> > > > > >> >
> > > > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
> > files
> > > > with
> > > > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > > > >> > > <
> > > > > >>
> > > >
> >
e5dfdd5
> > > > > >> >
> > > > > >> > > - Cleanup CCPP cmake build (#383)
> > > > > >> > > <
> > > > > >>
> > > >
> >
85c2648
> > > > > >> >
> > > > > >> > > - establish branch mraerosol
> > > > > >> > > <
> > > > > >>
> > > >
> >
53f3c0d
> > > > > >> >
> > > > > >> > > - cmake in the FV3 dycore (#389)
> > > > > >> > > <
> > > > > >>
> > > >
> >
026138b
> > > > > >> >
> > > > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP
suite
> > file
> > > > > >> (#391)
> > > > > >> > > <
> > > > > >>
> > > >
> >
d77f748
> > > > > >> >
> > > > > >> > > - update ccpp with decomposition fix (#397)
> > > > > >> > > <
> > > > > >>
> > > >
> >
06e9b35
> > > > > >> >
> > > > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie from
> > > > CODEOWNERS
> > > > > >> > > (#402)
> > > > > >> > > <
> > > > > >>
> > > >
> >
931f8a3
> > > > > >> >
> > > > > >> > > - updates associated with CA restart and PE decomposition
bugs
> > > > (#396)
> > > > > >> > > <
> > > > > >>
> > > >
> >
376d374
> > > > > >> >
> > > > > >> > > - fix the output file name and diag time (#404)
> > > > > >> > > <
> > > > > >>
> > > >
> >
799b157
> > > > > >> >
> > > > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
> > arrays
> > > > into
> > > > > >> > > integer arrays without affecting input/output files (#388)
> > > > > >> > > <
> > > > > >>
> > > >
> >
b811a6c
> > > > > >> >
> > > > > >> > > - Properly import coupling fields when running with
separate
> > run
> > > > > >> > > phases (#406)
> > > > > >> > > <
> > > > > >>
> > > >
> >
95ff1ca
> > > > > >> >
> > > > > >> > > - Add consistency check for Thompson aerosol options to
> > > > > >> > > GFS_typedefs.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
2d50c61
> > > > > >> >
> > > > > >> > > - Merge branch 'develop' of
> > https://github.com/NOAA-EMC/fv3atm
> > > > into
> > > > > >> > > HEAD
> > > > > >> > > <
> > > > > >>
> > > >
> >
b79caf4
> > > > > >> >
> > > > > >> > > - Revert change to .gitmodules and update submodule
pointer
> > for
> > > > > >> > > ccpp-physics
> > > > > >> > > <
> > > > > >>
> > > >
> >
cfc57d0
> > > > > >> >
> > > > > >> > >
> > > > > >> > > File Changes
> > > > > >> > >
> > > > > >> > > - *M* .gitignore
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > > > > >> >
> > > > > >> > > (10)
> > > > > >> > > - *M* .gitmodules
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > > > > >> >
> > > > > >> > > (20)
> > > > > >> > > - *M* CMakeLists.txt
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > > > > >> >
> > > > > >> > > (109)
> > > > > >> > > - *M* atmos_cubed_sphere
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > > > > >> >
> > > > > >> > > (2)
> > > > > >> > > - *M* atmos_model.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > > > > >> >
> > > > > >> > > (51)
> > > > > >> > > - *M* ccpp/CMakeLists.txt
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > > > > >> >
> > > > > >> > > (31)
> > > > > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > > > > >> >
> > > > > >> > > (572)
> > > > > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > > > > >> >
> > > > > >> > > (114)
> > > > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > > > > >> >
> > > > > >> > > (32)
> > > > > >> > > - *M* ccpp/framework
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > > > > >> >
> > > > > >> > > (2)
> > > > > >> > > - *M* ccpp/physics
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > > > > >> >
> > > > > >> > > (2)
> > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > > > > >> >
> > > > > >> > > (88)
> > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > > > > >> >
> > > > > >> > > (90)
> > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > > > > >> >
> > > > > >> > > (88)
> > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > > > > >> >
> > > > > >> > > (93)
> > > > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > > > > >> >
> > > > > >> > > (11)
> > > > > >> > > - *M* cpl/module_block_data.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > > > > >> >
> > > > > >> > > (35)
> > > > > >> > > - *M* fv3_cap.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > > > > >> >
> > > > > >> > > (73)
> > > > > >> > > - *M* io/FV3GFS_io.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > > > > >> >
> > > > > >> > > (881)
> > > > > >> > > - *M* io/module_fv3_io_def.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > > > > >> >
> > > > > >> > > (1)
> > > > > >> > > - *M* io/module_wrt_grid_comp.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > > > > >> >
> > > > > >> > > (7)
> > > > > >> > > - *M* module_fcst_grid_comp.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > > > > >> >
> > > > > >> > > (42)
> > > > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > > > > >> >
> > > > > >> > > (109)
> > > > > >> > >
> > > > > >> > > Patch Links:
> > > > > >> > >
> > > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > > > > >> > >
> > > > > >> > > —
> > > > > >> > > You are receiving this because you were mentioned.
> > > > > >> > > Reply to this email directly, view it on GitHub
> > > > > >> > > <#1>, or
> > > > unsubscribe
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > > > > >> >
> > > > > >> > > .
> > > > > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > > >> >
> > > > > >> > > or Android
> > > > > >> > > <
> > > > > >>
> > > >
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > > >> >.
> > > > > >> > >
> > > > > >> > >
> > > > > >> > —
> > > > > >> > You are receiving this because you authored the thread.
> > > > > >> > Reply to this email directly, view it on GitHub <
> > > > > >>
> > > >
> >
#1 (comment)>,
> > > > > >> or unsubscribe <
> > > > > >>
> > > >
> >
https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > > > > >> >.
> > > > > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > > > > >>
> > > >
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > >
> > > > > >> or Android <
> > > > > >>
> > > >
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > >.
> > > > > >>
> > > > > >> >
> > > > > >>
> > > > > >> —
> > > > > >> You are receiving this because you were mentioned.
> > > > > >> Reply to this email directly, view it on GitHub
> > > > > >> <
> > > >
> >
#1 (comment)>,
> > > > > >> or unsubscribe
> > > > > >> <
> > > >
> >
https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> > > > >
> > > > > >> .
> > > > > >> Triage notifications on the go with GitHub Mobile for iOS
> > > > > >> <
> > > >
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > >
> > > > > >> or Android
> > > > > >> <
> > > >
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > >.
> > > > > >>
> > > > > >>
> > > > > >
> > > > > —
> > > > > You are receiving this because you authored the thread.
> > > > > Reply to this email directly, view it on GitHub <
> > > >
> >
#1 (comment)>,
> > > > or unsubscribe <
> > > >
> >
https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> > > > >.
> > > > > Triage notifications on the go with GitHub Mobile for iOS <
> > > >
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >
> > > > or Android <
> > > >
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >.
> > > >
> > > > >
> > > >
> > > > —
> > > > You are receiving this because you were mentioned.
> > > > Reply to this email directly, view it on GitHub
> > > > <
> >
#1 (comment)>,
> > > > or unsubscribe
> > > > <
> >
https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
> > >
> > > > .
> > > > Triage notifications on the go with GitHub Mobile for iOS
> > > > <
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >
> > > > or Android
> > > > <
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >.
> > > >
> > > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub <
> >
#1 (comment)>,
> > or unsubscribe <
> >
https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
> > >.
> > > Triage notifications on the go with GitHub Mobile for iOS <
> >
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> > or Android <
> >
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#1 (comment)>,
> > or unsubscribe
> > <
https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ
>
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> > or Android
> > <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
> >
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <
#1 (comment)>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AB5C2RKQ4TNJSCWYQ3JP6ZLUF4NQPANCNFSM5FSDNTTQ
>.
> Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINLHFT2XGEEQ6PPFH3UF4OBJANCNFSM5FSDNTTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Dom, have a nice vacation,
On Fri, Oct 8, 2021 at 1:03 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
… Dom,
I kind of understand, but nifa and nwfa from merra2 climatology are always
dry. I do not think the necessity to perform such conversion and simply
neglect it.
On Fri, Oct 8, 2021 at 12:47 PM Dom Heinzeller ***@***.***>
wrote:
> Your logic has a problem because you are not converting from moist to dry
> mixing ratios/number concentrations (but you are converting back from dry
> to moist). I agree that your code doesn't have a problem with
> is_aerosol_aware vs merra2_aerosol_aware.
>
> And if you look carefully in lines 127-131 in mp_thompson.F90, then you
> will see that my logic is just as fine, too, because is_aerosol_aware and
> merra2_aerosol_aware cannot be true at the same time.
>
> > On Oct 8, 2021, at 10:42 AM, AnningCheng-NOAA ***@***.***> wrote:
> >
> >
> > Dom:
> >
> > I do not think My logic has any problem. My code is really exclusive for
> > merra2_aerosol_aware and is_aerosol_aware as below:
> > if (is_aerosol_aware) then
> > ...
> > else if (merra2_aerosol_aware) then
> > ...
> > else
> > ...
> > end if
> >
> > Your changes:
> > if (merra2_aerosol_aware) then
> > ...
> > end if
> > if (is_aerosol_aware) then
> > ...
> > else
> > ...
> > end if
> >
> > If both merra_aerosol_aware and is_aerosol_aware are true, my code will
> be
> > called only once, your code will be called twice and what has been done
> in
> > merra2_aerosol_aware block will be overwritten by is_aerosol_aware
> block.
> >
> > Anyhow, Do you have any idea on how to fix my regression tests?
> >
> > Anning
> >
> >
> >
> >
> > On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
> > wrote:
> >
> > > Your logic is incorrect, because nwfa and nifa will not be converted
> from
> > > moist to dry mixing rattios. That's why I moved the logic up to
> before the
> > > "if(convert_dry_rho)" block.
> > >
> > > And is_aerosol_aware and merra2_aerosol_aware should be mutually
> > > exclusive, only one of them can be true at any given time. That's how
> you
> > > wrote the code inside module_mp_thompson.F90 and that's what makes
> sense.
> > >
> > > > On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
> > > >
> > > >
> > > > Dom,
> > > > it is line 157-159 in mp_thompson.F90. I have moved them to line
> 217-218
> > > > at
> > >
> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
> > > >
> > > > The regression test has an error at line 174 of mp_thompson.F90.
> > > Something
> > > > is wrong with passing nwfa. The regression test dir
> > > > is
> /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
> > > >
> > > > Where are the cap files now? it seems that the compilation
> automatically
> > > > deletes the cap files.
> > > >
> > > >
> > > > On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
> > > > wrote:
> > > >
> > > > > Thanks for letting me know, I was about to start working on the
> > > mraerosol
> > > > > branch.
> > > > >
> > > > > Which lines of code are you talking about when you refer to "why
> you
> > > move
> > > > > merra2_aerosol_aware to the beginning of the code before any
> > > > > initialization" ?
> > > > >
> > > > > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
> > > > > >
> > > > > >
> > > > > > Dom,
> > > > > >
> > > > > > Never mind. I have just found that merra2_thompson of fv3atm is
> more
> > > > > > up_to_date with your modifications. I have also bring mraerosl
> of
> > > > > > ufs_weather_model up_to_date and the code has passed
> compilation and
> > > > > > waiting for the regression test for merra2_thompson in
> > > > > >
> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
> > > > > >
> > > > > > The other change is that I treat merra2_aerosol_aware as
> parallel to
> > > > > > is_aerosol aware in mp_thompson.F90. I do not understand why
> you move
> > > > > > merra2_aerosol_aware to the beginning of the code before any
> > > > > > initialization.
> > > > > >
> > > > > > Anning
> > > > > >
> > > > > >
> > > > > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
> > > > > > ***@***.***> wrote:
> > > > > >
> > > > > > > HI, Dom:
> > > > > > >
> > > > > > > my branch for fv3atm is mraerosol too. merra2_thompson is the
> old
> > > > > version,
> > > > > > > out of date. Could you correct it?
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Yes, your branch that you gave me was merra2_thompson for
> fv3atm
> > > > > > >>
> > > > > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***>
> wrote:
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > HI, Dom,
> > > > > > >> >
> > > > > > >> > I merged, but the head of my branch of fv3atm "mraerosol"
> is
> > > still
> > > > > > >> > at d840d47. Am missing something?
> > > > > > >> >
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
> > > > > > >> > wrote:
> > > > > > >> >
> > > > > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
> > > please
> > > > > > >> review and
> > > > > > >> > > merge if ok. Thanks!
> > > > > > >> > > ------------------------------
> > > > > > >> > > You can view, comment on, or merge this pull request
> online
> > > at:
> > > > > > >> > >
> > > > > > >> > > #1
> > > > > > >> > > Commit Summary
> > > > > > >> > >
> > > > > > >> > > - CCPP framework update and metadata bug fixes (#367)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 16a51fc
> > > > > > >> >
> > > > > > >> > > - Fix stochastic physics restart runs, remove rayleigh
> damping
> > > > > from
> > > > > > >> > > all suite definition files (#371)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 862fe80
> > > > > > >> >
> > > > > > >> > > - Updates to use FMS 2021.03 (#374)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 2dc03c1
> > > > > > >> >
> > > > > > >> > > - brings in latest release candidate for the FV3 dycore
> (#377)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 7a97256
> > > > > > >> >
> > > > > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 2fe2998
> > > > > > >> >
> > > > > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean
> model
> > > > > > >> > > component feedback to FV3ATM (#376)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 967b84b
> > > > > > >> >
> > > > > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
> > > files
> > > > > with
> > > > > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> e5dfdd5
> > > > > > >> >
> > > > > > >> > > - Cleanup CCPP cmake build (#383)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 85c2648
> > > > > > >> >
> > > > > > >> > > - establish branch mraerosol
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 53f3c0d
> > > > > > >> >
> > > > > > >> > > - cmake in the FV3 dycore (#389)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 026138b
> > > > > > >> >
> > > > > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP
> suite
> > > file
> > > > > > >> (#391)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> d77f748
> > > > > > >> >
> > > > > > >> > > - update ccpp with decomposition fix (#397)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 06e9b35
> > > > > > >> >
> > > > > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie
> from
> > > > > CODEOWNERS
> > > > > > >> > > (#402)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 931f8a3
> > > > > > >> >
> > > > > > >> > > - updates associated with CA restart and PE
> decomposition bugs
> > > > > (#396)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 376d374
> > > > > > >> >
> > > > > > >> > > - fix the output file name and diag time (#404)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 799b157
> > > > > > >> >
> > > > > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
> > > arrays
> > > > > into
> > > > > > >> > > integer arrays without affecting input/output files
> (#388)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> b811a6c
> > > > > > >> >
> > > > > > >> > > - Properly import coupling fields when running with
> separate
> > > run
> > > > > > >> > > phases (#406)
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 95ff1ca
> > > > > > >> >
> > > > > > >> > > - Add consistency check for Thompson aerosol options to
> > > > > > >> > > GFS_typedefs.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> 2d50c61
> > > > > > >> >
> > > > > > >> > > - Merge branch 'develop' of
> > > https://github.com/NOAA-EMC/fv3atm
> > > > > into
> > > > > > >> > > HEAD
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> b79caf4
> > > > > > >> >
> > > > > > >> > > - Revert change to .gitmodules and update submodule
> pointer
> > > for
> > > > > > >> > > ccpp-physics
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> cfc57d0
> > > > > > >> >
> > > > > > >> > >
> > > > > > >> > > File Changes
> > > > > > >> > >
> > > > > > >> > > - *M* .gitignore
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
> > > > > > >> >
> > > > > > >> > > (10)
> > > > > > >> > > - *M* .gitmodules
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
> > > > > > >> >
> > > > > > >> > > (20)
> > > > > > >> > > - *M* CMakeLists.txt
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
> > > > > > >> >
> > > > > > >> > > (109)
> > > > > > >> > > - *M* atmos_cubed_sphere
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
> > > > > > >> >
> > > > > > >> > > (2)
> > > > > > >> > > - *M* atmos_model.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
> > > > > > >> >
> > > > > > >> > > (51)
> > > > > > >> > > - *M* ccpp/CMakeLists.txt
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
> > > > > > >> >
> > > > > > >> > > (31)
> > > > > > >> > > - *M* ccpp/data/GFS_typedefs.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
> > > > > > >> >
> > > > > > >> > > (572)
> > > > > > >> > > - *M* ccpp/data/GFS_typedefs.meta
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
> > > > > > >> >
> > > > > > >> > > (114)
> > > > > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
> > > > > > >> >
> > > > > > >> > > (32)
> > > > > > >> > > - *M* ccpp/framework
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
> > > > > > >> >
> > > > > > >> > > (2)
> > > > > > >> > > - *M* ccpp/physics
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
> > > > > > >> >
> > > > > > >> > > (2)
> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
> > > > > > >> >
> > > > > > >> > > (88)
> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
> > > > > > >> >
> > > > > > >> > > (90)
> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
> > > > > > >> >
> > > > > > >> > > (88)
> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
> > > > > > >> >
> > > > > > >> > > (93)
> > > > > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
> > > > > > >> >
> > > > > > >> > > (11)
> > > > > > >> > > - *M* cpl/module_block_data.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
> > > > > > >> >
> > > > > > >> > > (35)
> > > > > > >> > > - *M* fv3_cap.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
> > > > > > >> >
> > > > > > >> > > (73)
> > > > > > >> > > - *M* io/FV3GFS_io.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
> > > > > > >> >
> > > > > > >> > > (881)
> > > > > > >> > > - *M* io/module_fv3_io_def.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
> > > > > > >> >
> > > > > > >> > > (1)
> > > > > > >> > > - *M* io/module_wrt_grid_comp.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
> > > > > > >> >
> > > > > > >> > > (7)
> > > > > > >> > > - *M* module_fcst_grid_comp.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
> > > > > > >> >
> > > > > > >> > > (42)
> > > > > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
> > > > > > >> >
> > > > > > >> > > (109)
> > > > > > >> > >
> > > > > > >> > > Patch Links:
> > > > > > >> > >
> > > > > > >> > > -
> https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
> > > > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
> > > > > > >> > >
> > > > > > >> > > —
> > > > > > >> > > You are receiving this because you were mentioned.
> > > > > > >> > > Reply to this email directly, view it on GitHub
> > > > > > >> > > <#1>, or
> > > > > unsubscribe
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
> > > > > > >> >
> > > > > > >> > > .
> > > > > > >> > > Triage notifications on the go with GitHub Mobile for iOS
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > > > >> >
> > > > > > >> > > or Android
> > > > > > >> > > <
> > > > > > >>
> > > > >
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > > > >> >.
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> > —
> > > > > > >> > You are receiving this because you authored the thread.
> > > > > > >> > Reply to this email directly, view it on GitHub <
> > > > > > >>
> > > > >
> > >
> #1 (comment)
> >,
> > > > > > >> or unsubscribe <
> > > > > > >>
> > > > >
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
> > > > > > >> >.
> > > > > > >> > Triage notifications on the go with GitHub Mobile for iOS <
> > > > > > >>
> > > > >
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > > >
> > > > > > >> or Android <
> > > > > > >>
> > > > >
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > > >.
> > > > > > >>
> > > > > > >> >
> > > > > > >>
> > > > > > >> —
> > > > > > >> You are receiving this because you were mentioned.
> > > > > > >> Reply to this email directly, view it on GitHub
> > > > > > >> <
> > > > >
> > >
> #1 (comment)
> >,
> > > > > > >> or unsubscribe
> > > > > > >> <
> > > > >
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
> > > > > >
> > > > > > >> .
> > > > > > >> Triage notifications on the go with GitHub Mobile for iOS
> > > > > > >> <
> > > > >
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > > > >
> > > > > > >> or Android
> > > > > > >> <
> > > > >
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > > > >.
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > —
> > > > > > You are receiving this because you authored the thread.
> > > > > > Reply to this email directly, view it on GitHub <
> > > > >
> > >
> #1 (comment)
> >,
> > > > > or unsubscribe <
> > > > >
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
> > > > > >.
> > > > > > Triage notifications on the go with GitHub Mobile for iOS <
> > > > >
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > > or Android <
> > > > >
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >
> > > > > >
> > > > >
> > > > > —
> > > > > You are receiving this because you were mentioned.
> > > > > Reply to this email directly, view it on GitHub
> > > > > <
> > >
> #1 (comment)
> >,
> > > > > or unsubscribe
> > > > > <
> > >
> https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
> > > >
> > > > > .
> > > > > Triage notifications on the go with GitHub Mobile for iOS
> > > > > <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > > >
> > > > > or Android
> > > > > <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > > >.
> > > > >
> > > > >
> > > > —
> > > > You are receiving this because you authored the thread.
> > > > Reply to this email directly, view it on GitHub <
> > >
> #1 (comment)
> >,
> > > or unsubscribe <
> > >
> https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
> > > >.
> > > > Triage notifications on the go with GitHub Mobile for iOS <
> > >
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android <
> > >
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> #1 (comment)
> >,
> > > or unsubscribe
> > > <
> https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ
> >
> > > .
> > > Triage notifications on the go with GitHub Mobile for iOS
> > > <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > > or Android
> > > <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> > >
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #1 (comment)>,
> or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AB5C2RKQ4TNJSCWYQ3JP6ZLUF4NQPANCNFSM5FSDNTTQ
> >.
> > Triage notifications on the go with GitHub Mobile for iOS <
> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android <
> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMINLHFT2XGEEQ6PPFH3UF4OBJANCNFSM5FSDNTTQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
Thanks! Please make sure to skip the conversion back from dry to moist as well, if merra2 is already dry.
… On Oct 8, 2021, at 11:10 AM, AnningCheng-NOAA ***@***.***> wrote:
Dom, have a nice vacation,
On Fri, Oct 8, 2021 at 1:03 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
> Dom,
> I kind of understand, but nifa and nwfa from merra2 climatology are always
> dry. I do not think the necessity to perform such conversion and simply
> neglect it.
>
> On Fri, Oct 8, 2021 at 12:47 PM Dom Heinzeller ***@***.***>
> wrote:
>
>> Your logic has a problem because you are not converting from moist to dry
>> mixing ratios/number concentrations (but you are converting back from dry
>> to moist). I agree that your code doesn't have a problem with
>> is_aerosol_aware vs merra2_aerosol_aware.
>>
>> And if you look carefully in lines 127-131 in mp_thompson.F90, then you
>> will see that my logic is just as fine, too, because is_aerosol_aware and
>> merra2_aerosol_aware cannot be true at the same time.
>>
>> > On Oct 8, 2021, at 10:42 AM, AnningCheng-NOAA ***@***.***> wrote:
>> >
>> >
>> > Dom:
>> >
>> > I do not think My logic has any problem. My code is really exclusive for
>> > merra2_aerosol_aware and is_aerosol_aware as below:
>> > if (is_aerosol_aware) then
>> > ...
>> > else if (merra2_aerosol_aware) then
>> > ...
>> > else
>> > ...
>> > end if
>> >
>> > Your changes:
>> > if (merra2_aerosol_aware) then
>> > ...
>> > end if
>> > if (is_aerosol_aware) then
>> > ...
>> > else
>> > ...
>> > end if
>> >
>> > If both merra_aerosol_aware and is_aerosol_aware are true, my code will
>> be
>> > called only once, your code will be called twice and what has been done
>> in
>> > merra2_aerosol_aware block will be overwritten by is_aerosol_aware
>> block.
>> >
>> > Anyhow, Do you have any idea on how to fix my regression tests?
>> >
>> > Anning
>> >
>> >
>> >
>> >
>> > On Fri, Oct 8, 2021 at 11:48 AM Dom Heinzeller ***@***.***>
>> > wrote:
>> >
>> > > Your logic is incorrect, because nwfa and nifa will not be converted
>> from
>> > > moist to dry mixing rattios. That's why I moved the logic up to
>> before the
>> > > "if(convert_dry_rho)" block.
>> > >
>> > > And is_aerosol_aware and merra2_aerosol_aware should be mutually
>> > > exclusive, only one of them can be true at any given time. That's how
>> you
>> > > wrote the code inside module_mp_thompson.F90 and that's what makes
>> sense.
>> > >
>> > > > On Oct 8, 2021, at 7:52 AM, AnningCheng-NOAA ***@***.***> wrote:
>> > > >
>> > > >
>> > > > Dom,
>> > > > it is line 157-159 in mp_thompson.F90. I have moved them to line
>> 217-218
>> > > > at
>> > >
>> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3/ccpp/physics/physics/mp_thompson.F90.
>> > > >
>> > > > The regression test has an error at line 174 of mp_thompson.F90.
>> > > Something
>> > > > is wrong with passing nwfa. The regression test dir
>> > > > is
>> /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_237272/merra2_thompson
>> > > >
>> > > > Where are the cap files now? it seems that the compilation
>> automatically
>> > > > deletes the cap files.
>> > > >
>> > > >
>> > > > On Fri, Oct 8, 2021 at 9:34 AM Dom Heinzeller ***@***.***>
>> > > > wrote:
>> > > >
>> > > > > Thanks for letting me know, I was about to start working on the
>> > > mraerosol
>> > > > > branch.
>> > > > >
>> > > > > Which lines of code are you talking about when you refer to "why
>> you
>> > > move
>> > > > > merra2_aerosol_aware to the beginning of the code before any
>> > > > > initialization" ?
>> > > > >
>> > > > > > On Oct 8, 2021, at 7:32 AM, AnningCheng-NOAA ***@***.***> wrote:
>> > > > > >
>> > > > > >
>> > > > > > Dom,
>> > > > > >
>> > > > > > Never mind. I have just found that merra2_thompson of fv3atm is
>> more
>> > > > > > up_to_date with your modifications. I have also bring mraerosl
>> of
>> > > > > > ufs_weather_model up_to_date and the code has passed
>> compilation and
>> > > > > > waiting for the regression test for merra2_thompson in
>> > > > > >
>> /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/tests.
>> > > > > >
>> > > > > > The other change is that I treat merra2_aerosol_aware as
>> parallel to
>> > > > > > is_aerosol aware in mp_thompson.F90. I do not understand why
>> you move
>> > > > > > merra2_aerosol_aware to the beginning of the code before any
>> > > > > > initialization.
>> > > > > >
>> > > > > > Anning
>> > > > > >
>> > > > > >
>> > > > > > On Thu, Oct 7, 2021 at 4:49 PM Anning Cheng - NOAA Affiliate <
>> > > > > > ***@***.***> wrote:
>> > > > > >
>> > > > > > > HI, Dom:
>> > > > > > >
>> > > > > > > my branch for fv3atm is mraerosol too. merra2_thompson is the
>> old
>> > > > > version,
>> > > > > > > out of date. Could you correct it?
>> > > > > > >
>> > > > > > >
>> > > > > > > On Thu, Oct 7, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
>> > > > > > > wrote:
>> > > > > > >
>> > > > > > >> Yes, your branch that you gave me was merra2_thompson for
>> fv3atm
>> > > > > > >>
>> > > > > > >> > On Oct 7, 2021, at 2:37 PM, AnningCheng-NOAA ***@***.***>
>> wrote:
>> > > > > > >> >
>> > > > > > >> >
>> > > > > > >> > HI, Dom,
>> > > > > > >> >
>> > > > > > >> > I merged, but the head of my branch of fv3atm "mraerosol"
>> is
>> > > still
>> > > > > > >> > at d840d47. Am missing something?
>> > > > > > >> >
>> > > > > > >> >
>> > > > > > >> >
>> > > > > > >> > On Thu, Oct 7, 2021 at 4:22 PM Dom Heinzeller ***@***.***>
>> > > > > > >> > wrote:
>> > > > > > >> >
>> > > > > > >> > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
>> > > please
>> > > > > > >> review and
>> > > > > > >> > > merge if ok. Thanks!
>> > > > > > >> > > ------------------------------
>> > > > > > >> > > You can view, comment on, or merge this pull request
>> online
>> > > at:
>> > > > > > >> > >
>> > > > > > >> > > #1
>> > > > > > >> > > Commit Summary
>> > > > > > >> > >
>> > > > > > >> > > - CCPP framework update and metadata bug fixes (#367)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 16a51fc
>> > > > > > >> >
>> > > > > > >> > > - Fix stochastic physics restart runs, remove rayleigh
>> damping
>> > > > > from
>> > > > > > >> > > all suite definition files (#371)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 862fe80
>> > > > > > >> >
>> > > > > > >> > > - Updates to use FMS 2021.03 (#374)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 2dc03c1
>> > > > > > >> >
>> > > > > > >> > > - brings in latest release candidate for the FV3 dycore
>> (#377)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 7a97256
>> > > > > > >> >
>> > > > > > >> > > - sfcsub.F land-mask bug fix in ccpp-physics (#378)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 2fe2998
>> > > > > > >> >
>> > > > > > >> > > - Add a cplocn2atm namelist option to turn on/off ocean
>> model
>> > > > > > >> > > component feedback to FV3ATM (#376)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 967b84b
>> > > > > > >> >
>> > > > > > >> > > - CCPP metadata bugfixes in GFS_typedefs.meta, update fv3
>> > > files
>> > > > > with
>> > > > > > >> > > fms.2021.03, IAU bug fix for restart files (#379)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> e5dfdd5
>> > > > > > >> >
>> > > > > > >> > > - Cleanup CCPP cmake build (#383)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 85c2648
>> > > > > > >> >
>> > > > > > >> > > - establish branch mraerosol
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 53f3c0d
>> > > > > > >> >
>> > > > > > >> > > - cmake in the FV3 dycore (#389)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 026138b
>> > > > > > >> >
>> > > > > > >> > > - add NoahMP restart fix and a standalone fv3 P7 CCPP
>> suite
>> > > file
>> > > > > > >> (#391)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> d77f748
>> > > > > > >> >
>> > > > > > >> > > - update ccpp with decomposition fix (#397)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 06e9b35
>> > > > > > >> >
>> > > > > > >> > > - CCPP updates: UGWPv1 decomp bug fixes, remove Julie
>> from
>> > > > > CODEOWNERS
>> > > > > > >> > > (#402)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 931f8a3
>> > > > > > >> >
>> > > > > > >> > > - updates associated with CA restart and PE
>> decomposition bugs
>> > > > > (#396)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 376d374
>> > > > > > >> >
>> > > > > > >> > > - fix the output file name and diag time (#404)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 799b157
>> > > > > > >> >
>> > > > > > >> > > - Convert real(kind_phys) vegetation, slope and soil type
>> > > arrays
>> > > > > into
>> > > > > > >> > > integer arrays without affecting input/output files
>> (#388)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> b811a6c
>> > > > > > >> >
>> > > > > > >> > > - Properly import coupling fields when running with
>> separate
>> > > run
>> > > > > > >> > > phases (#406)
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 95ff1ca
>> > > > > > >> >
>> > > > > > >> > > - Add consistency check for Thompson aerosol options to
>> > > > > > >> > > GFS_typedefs.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> 2d50c61
>> > > > > > >> >
>> > > > > > >> > > - Merge branch 'develop' of
>> > > https://github.com/NOAA-EMC/fv3atm
>> > > > > into
>> > > > > > >> > > HEAD
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> b79caf4
>> > > > > > >> >
>> > > > > > >> > > - Revert change to .gitmodules and update submodule
>> pointer
>> > > for
>> > > > > > >> > > ccpp-physics
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> cfc57d0
>> > > > > > >> >
>> > > > > > >> > >
>> > > > > > >> > > File Changes
>> > > > > > >> > >
>> > > > > > >> > > - *M* .gitignore
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
>> > > > > > >> >
>> > > > > > >> > > (10)
>> > > > > > >> > > - *M* .gitmodules
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
>> > > > > > >> >
>> > > > > > >> > > (20)
>> > > > > > >> > > - *M* CMakeLists.txt
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
>> > > > > > >> >
>> > > > > > >> > > (109)
>> > > > > > >> > > - *M* atmos_cubed_sphere
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-5ef100b352b566a0d6b88f326532ba91bcbcf0c4f2c9bb8cee07e171068b2fa6
>> > > > > > >> >
>> > > > > > >> > > (2)
>> > > > > > >> > > - *M* atmos_model.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-426e093685997ae6e2793982790a6eb86ac292a6cf93ccd26d2180187e5e7a74
>> > > > > > >> >
>> > > > > > >> > > (51)
>> > > > > > >> > > - *M* ccpp/CMakeLists.txt
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dfb7b2736d1f5531d3de4270e8a47bbcccef28b28f04c5712fa368700423cc20
>> > > > > > >> >
>> > > > > > >> > > (31)
>> > > > > > >> > > - *M* ccpp/data/GFS_typedefs.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-89fcd58cb0c9d86e79683359371e2dc13cefa09bc447a65e01e58ba591d89269
>> > > > > > >> >
>> > > > > > >> > > (572)
>> > > > > > >> > > - *M* ccpp/data/GFS_typedefs.meta
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-556dd5101e3670a87a153795ecfc199359bd8d3da8b1fa84aeb6596a88d61ea2
>> > > > > > >> >
>> > > > > > >> > > (114)
>> > > > > > >> > > - *M* ccpp/driver/GFS_diagnostics.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9ebb91bd498f334ea5b6b160ed67c934d99ec9a8c17f9c3fd56828a46bb1ae42
>> > > > > > >> >
>> > > > > > >> > > (32)
>> > > > > > >> > > - *M* ccpp/framework
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-45067042325ac56d83dc021921f8d7429298d3a65dc0413f993ad3025209b6d3
>> > > > > > >> >
>> > > > > > >> > > (2)
>> > > > > > >> > > - *M* ccpp/physics
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dbcece100f6f97d32b9f07e07caaa3051e75fcfcd94775016373bb8a1cfca1c2
>> > > > > > >> >
>> > > > > > >> > > (2)
>> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_coupled.xml
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4db3e27545c363dd5dab95d2369531198bab6296a793fefae8305ece4d1c66e9
>> > > > > > >> >
>> > > > > > >> > > (88)
>> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_couplednsst.xml
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-4c3d2b568ec01b498d6c1130e86c861da4d1f5c3b8ce0d375fd30cec618240d2
>> > > > > > >> >
>> > > > > > >> > > (90)
>> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_2017_satmedmf_coupled.xml
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-83637b9fa96b2278c8063607ecac603362ec4fb8fec0e8ee911bf84640694592
>> > > > > > >> >
>> > > > > > >> > > (88)
>> > > > > > >> > > - *D* ccpp/suites/suite_FV3_GFS_v15p2_coupled.xml
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-337ce7675254565003850d80c381e70281c0b7d7d221f06c5a9abef315b8fb89
>> > > > > > >> >
>> > > > > > >> > > (93)
>> > > > > > >> > > - *R* ccpp/suites/suite_FV3_GFS_v16_nsstNoahmpUGWPv1.xml
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-eb3ea28fbd6274a00627eb8bf4b17afe59f35a3c8fd74b9a2e716e54d1031b85
>> > > > > > >> >
>> > > > > > >> > > (11)
>> > > > > > >> > > - *M* cpl/module_block_data.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-7175527d2568f38dac637092c000b52a042efe144b0333715ead7b469c4fa269
>> > > > > > >> >
>> > > > > > >> > > (35)
>> > > > > > >> > > - *M* fv3_cap.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-dc3da9b9c37c068b769128e69328ab808bb6a17947cae75342a9a462cebf63eb
>> > > > > > >> >
>> > > > > > >> > > (73)
>> > > > > > >> > > - *M* io/FV3GFS_io.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-47a8371f604cc35340090168c6379e8f25cba47528b9e40c6c252f0ccfdc4925
>> > > > > > >> >
>> > > > > > >> > > (881)
>> > > > > > >> > > - *M* io/module_fv3_io_def.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-9f9f8c36396d578f9797a7a38fa0545f6035067989b9eb758af3dd5d3619c09a
>> > > > > > >> >
>> > > > > > >> > > (1)
>> > > > > > >> > > - *M* io/module_wrt_grid_comp.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-30ae84672211025ca74b9b43d466053a90e396f69036a71a741f8efa2f65f968
>> > > > > > >> >
>> > > > > > >> > > (7)
>> > > > > > >> > > - *M* module_fcst_grid_comp.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-6834b16f72ca790e5fe60d96147b59754f8891838aec13adcd5eaf4b738a1944
>> > > > > > >> >
>> > > > > > >> > > (42)
>> > > > > > >> > > - *M* stochastic_physics/stochastic_physics_wrapper.F90
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1/files#diff-95ff8a5957790c7636caf2454bda40a4d4da9c7cdd623a894bd83debe2d95f9e
>> > > > > > >> >
>> > > > > > >> > > (109)
>> > > > > > >> > >
>> > > > > > >> > > Patch Links:
>> > > > > > >> > >
>> > > > > > >> > > -
>> https://github.com/AnningCheng-NOAA/fv3atm/pull/1.patch
>> > > > > > >> > > - https://github.com/AnningCheng-NOAA/fv3atm/pull/1.diff
>> > > > > > >> > >
>> > > > > > >> > > —
>> > > > > > >> > > You are receiving this because you were mentioned.
>> > > > > > >> > > Reply to this email directly, view it on GitHub
>> > > > > > >> > > <#1>, or
>> > > > > unsubscribe
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/notifications/unsubscribe-auth/ALQPMIIPIYSDNJDC5IOP6DTUFX6RDANCNFSM5FSDNTTQ
>> > > > > > >> >
>> > > > > > >> > > .
>> > > > > > >> > > Triage notifications on the go with GitHub Mobile for iOS
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> > > > > > >> >
>> > > > > > >> > > or Android
>> > > > > > >> > > <
>> > > > > > >>
>> > > > >
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> > > > > > >> >.
>> > > > > > >> > >
>> > > > > > >> > >
>> > > > > > >> > —
>> > > > > > >> > You are receiving this because you authored the thread.
>> > > > > > >> > Reply to this email directly, view it on GitHub <
>> > > > > > >>
>> > > > >
>> > >
>> #1 (comment)
>> >,
>> > > > > > >> or unsubscribe <
>> > > > > > >>
>> > > > >
>> > >
>> https://github.com/notifications/unsubscribe-auth/AB5C2RICWMLVA65FIWNMNUDUFYAIXANCNFSM5FSDNTTQ
>> > > > > > >> >.
>> > > > > > >> > Triage notifications on the go with GitHub Mobile for iOS <
>> > > > > > >>
>> > > > >
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> > > > > >
>> > > > > > >> or Android <
>> > > > > > >>
>> > > > >
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> > > > > >.
>> > > > > > >>
>> > > > > > >> >
>> > > > > > >>
>> > > > > > >> —
>> > > > > > >> You are receiving this because you were mentioned.
>> > > > > > >> Reply to this email directly, view it on GitHub
>> > > > > > >> <
>> > > > >
>> > >
>> #1 (comment)
>> >,
>> > > > > > >> or unsubscribe
>> > > > > > >> <
>> > > > >
>> > >
>> https://github.com/notifications/unsubscribe-auth/ALQPMIJLZYC62IWPFTUFXXTUFYASDANCNFSM5FSDNTTQ
>> > > > > >
>> > > > > > >> .
>> > > > > > >> Triage notifications on the go with GitHub Mobile for iOS
>> > > > > > >> <
>> > > > >
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> > > > > >
>> > > > > > >> or Android
>> > > > > > >> <
>> > > > >
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> > > > > >.
>> > > > > > >>
>> > > > > > >>
>> > > > > > >
>> > > > > > —
>> > > > > > You are receiving this because you authored the thread.
>> > > > > > Reply to this email directly, view it on GitHub <
>> > > > >
>> > >
>> #1 (comment)
>> >,
>> > > > > or unsubscribe <
>> > > > >
>> > >
>> https://github.com/notifications/unsubscribe-auth/AB5C2RNZWXH7Y4OKIP4HZGLUF3XGTANCNFSM5FSDNTTQ
>> > > > > >.
>> > > > > > Triage notifications on the go with GitHub Mobile for iOS <
>> > > > >
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> > > >
>> > > > > or Android <
>> > > > >
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> > > >.
>> > > > >
>> > > > > >
>> > > > >
>> > > > > —
>> > > > > You are receiving this because you were mentioned.
>> > > > > Reply to this email directly, view it on GitHub
>> > > > > <
>> > >
>> #1 (comment)
>> >,
>> > > > > or unsubscribe
>> > > > > <
>> > >
>> https://github.com/notifications/unsubscribe-auth/ALQPMIKM2WXT2FY6YWLEUV3UF3XNPANCNFSM5FSDNTTQ
>> > > >
>> > > > > .
>> > > > > Triage notifications on the go with GitHub Mobile for iOS
>> > > > > <
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> > > >
>> > > > > or Android
>> > > > > <
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> > > >.
>> > > > >
>> > > > >
>> > > > —
>> > > > You are receiving this because you authored the thread.
>> > > > Reply to this email directly, view it on GitHub <
>> > >
>> #1 (comment)
>> >,
>> > > or unsubscribe <
>> > >
>> https://github.com/notifications/unsubscribe-auth/AB5C2RNJFNYGGYQTYECNGFTUF3ZRNANCNFSM5FSDNTTQ
>> > > >.
>> > > > Triage notifications on the go with GitHub Mobile for iOS <
>> > >
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> >
>> > > or Android <
>> > >
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> >.
>> > >
>> > > >
>> > >
>> > > —
>> > > You are receiving this because you were mentioned.
>> > > Reply to this email directly, view it on GitHub
>> > > <
>> #1 (comment)
>> >,
>> > > or unsubscribe
>> > > <
>> https://github.com/notifications/unsubscribe-auth/ALQPMIJZVCKB5WQPEFG4ZATUF4HDJANCNFSM5FSDNTTQ
>> >
>> > > .
>> > > Triage notifications on the go with GitHub Mobile for iOS
>> > > <
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>> >
>> > > or Android
>> > > <
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>> >.
>> > >
>> > >
>> > —
>> > You are receiving this because you authored the thread.
>> > Reply to this email directly, view it on GitHub <
>> #1 (comment)>,
>> or unsubscribe <
>> https://github.com/notifications/unsubscribe-auth/AB5C2RKQ4TNJSCWYQ3JP6ZLUF4NQPANCNFSM5FSDNTTQ
>> >.
>> > Triage notifications on the go with GitHub Mobile for iOS <
>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android <
>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>> >
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#1 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ALQPMINLHFT2XGEEQ6PPFH3UF4OBJANCNFSM5FSDNTTQ>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2ROJOWOR2HJYRM4G5MTUF4QYTANCNFSM5FSDNTTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
AnningCheng-NOAA
pushed a commit
that referenced
this pull request
Jan 8, 2024
* In GFS_diagnostics make LAI, WILT and FLDCP be outputted with all LSMs. Also, output of LAI should not depend on RDLAI. * In GFS_typedefs.* add surface heat flux from the fire for use in RUC LSM. * Fix hail size output diagnostic array size (#1) * Added one more variable - frac_grid_burned_out - to GFS_typedefs.F90. Also, the surface heat flux from fires and frac_grid_burned_out are added to the model output in GFS_diagnostics.F90. --------- Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov> Co-authored-by: Anders Jensen <anders.jensen@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AnningCheng-NOAA please review and merge if ok. Thanks!