Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hover effect and onClick event for marquee text #264

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

shashankgoud18
Copy link
Contributor

Description:
This PR introduces the following changes to the marquee text component:
1.Hover Effect: A hover effect has been added to the marquee text to improve user interaction. The text changes its appearance when hovered over, providing a more dynamic user experience.
2.onClick Event with Anchor Tag: The marquee text is now wrapped inside an anchor () tag. When clicked, the user is redirected to the cart.html page. The anchor tag also triggers the generation of a coupon code, which is displayed on the cart page.

Changes Made:
1.Added CSS to apply a hover effect on the marquee text.
2.Used an anchor () tag to handle the click event, redirecting the user to cart.html and generating a coupon code.

Screenshots/Recordings:

Uploading Added Hover Effect.mp4…

Please review the changes and let me know if there are any additional improvements or adjustments required.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shashankgoud18! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 67bb062
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670248da042efc0008531dc8
😎 Deploy Preview https://deploy-preview-264--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shashankgoud18
Copy link
Contributor Author

Hey @Anjaliavv51 ,

I noticed that my recent PR #264 was closed, and I wanted to better understand the reasoning behind it.

Were there specific aspects of the implementation that didn’t align with the project’s needs, or any other issues that I might have overlooked?

@Anjaliavv51 Anjaliavv51 merged commit df4a42f into Anjaliavv51:main Oct 8, 2024
6 checks passed
Copy link

github-actions bot commented Oct 8, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Anjaliavv51 Anjaliavv51 added enhancement New feature or request good first issue Good for newcomers gssoc-ext Level 1 labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers gssoc-ext Level 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants