Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make footer Responsive #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Suhas-Koheda
Copy link

Description

The Grid of the footer div's was changes to flex and the flex direction was changed to facilitate the div placement and accommodation
The text in the footer were aligned to center to be visually appealing

Related Issues

Nothing

Type of PR

  • [ x] (Bug) -Fixed

Screenshots / videos (if applicable)

image
image
image

Checklist

  • [ x] I have gone through the contributing guide
  • [ x] I have updated my branch and synced it with project main branch before making this PR
  • [x ] I have performed a self-review of my code
  • [x ] I have tested the changes thoroughly before submitting this pull request.
  • [ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ x] I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Suhas-Koheda! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit df4e86c
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/67008c3b957afd0008a02f8d
😎 Deploy Preview https://deploy-preview-205--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Suhas-Koheda
Copy link
Author

@Anjaliavv51 Hey have a look at this

@Anjaliavv51
Copy link
Owner

@Suhas-Koheda your problem will merged soon.

@Anjaliavv51
Copy link
Owner

@Suhas-Koheda make the footer responsive for all the html pages.

@Suhas-Koheda
Copy link
Author

Okay!

2004shweta pushed a commit to 2004shweta/Retro that referenced this pull request Oct 15, 2024
@Suhas-Koheda
Copy link
Author

Hey is this still open?
I can make footers in all the pages uniform
@Anjaliavv51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants