Preserve Z values at line intersections instead of zeroing them#1064
Open
Nebukam wants to merge 1 commit intoAngusJohnson:mainfrom
Open
Preserve Z values at line intersections instead of zeroing them#1064Nebukam wants to merge 1 commit intoAngusJohnson:mainfrom
Nebukam wants to merge 1 commit intoAngusJohnson:mainfrom
Conversation
When USINGZ is enabled, GetLineIntersectPt sets ip.z = 0 for true intersection points (where t is strictly between 0 and 1). This discards user data stored in Z before the ZCallback has a chance to run, which matters for code paths like RectClip that don't use a ZCallback at all. Pick the nearer endpoint's Z value instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When USINGZ is enabled, GetLineIntersectPt sets ip.z = 0 for true intersection points (where t is strictly between 0 and 1). This discards user data stored in Z before the ZCallback has a chance to run, which matters for code paths like RectClip that don't use a ZCallback at all. Pick the nearer endpoint's Z value instead.