Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: small code suggestions #51

Closed
2 of 3 tasks
AngryMaciek opened this issue May 16, 2023 · 0 comments · Fixed by #70
Closed
2 of 3 tasks

refactor: small code suggestions #51

AngryMaciek opened this issue May 16, 2023 · 0 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@AngryMaciek
Copy link
Owner

AngryMaciek commented May 16, 2023

  • adjust all int and unsigned int to uint_64 or int32_t.
  • conditional inclusion of MPFR only if flag provided (GPT)
  • as suggested in the revision process: maybe it would be easier to merge Polynomial specialisation with the main one? just need to explicitly forbid/allow the differences...

I cannot do this; if a method is missing the compiler does not automatically fall back to the base class, the solution is what I have now: explicitly define all functions again in the specialised class. One other solution that theoretically could work is to remove the whole class specialisation and only specialise a few particular methods in the base class. This will now work here, however, because of the <MaxDeg> template parameter which is a CLASS template for the specialisation, I cannot just convert it to a FUNCTION template in the base class.

@AngryMaciek AngryMaciek self-assigned this May 16, 2023
@AngryMaciek AngryMaciek added the enhancement New feature or request label May 16, 2023
@AngryMaciek AngryMaciek changed the title refactor the repo as others of mine refactor: small code suggestions Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant