Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

[WIP] EndowmentFees now use Basis Points(bps) #78

Merged
merged 3 commits into from
May 30, 2023
Merged

[WIP] EndowmentFees now use Basis Points(bps) #78

merged 3 commits into from
May 30, 2023

Conversation

SovereignAndrey
Copy link
Contributor

Ticket(s):

  • N/A

Explanation of the solution

  • Change fees to Basis Points(bps) for greater precision (ex. 420 bps == 4.20%)
  • Changes naming of EndowmentFee.percentage >> bps (basis points) because we don't set % values in that field
  • DRY up repeated Fee Check logic for setting new EndowmentFees (new validateFee function)

Instructions on making this work

None

@SovereignAndrey SovereignAndrey self-assigned this May 30, 2023
@SovereignAndrey SovereignAndrey changed the title EndowmentFees now use Basis Points(bps) [WIP] EndowmentFees now use Basis Points(bps) May 30, 2023
@stevieraykatz stevieraykatz merged commit c8dc49d into withdraw-multiple-tokens May 30, 2023
@SovereignAndrey SovereignAndrey deleted the fees_basis_points branch September 1, 2023 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevieraykatz stevieraykatz Awaiting requested review from stevieraykatz

Assignees

@SovereignAndrey SovereignAndrey

Labels
WIP
Projects
No open projects
Angel Protocol dApp
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SovereignAndrey @stevieraykatz