Unmount before exit #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anduin2017
requested changes
May 13, 2025
src/build.sh
Outdated
| @@ -10,6 +10,34 @@ export SCRIPT_DIR="$(dirname "$(readlink -f "$0")")" | |||
| source $SCRIPT_DIR/shared.sh | |||
| source $SCRIPT_DIR/args.sh | |||
|
|
|||
| function exit_on_exit() { | |||
| print_ok "Exit on exit..." | |||
There was a problem hiding this comment.
Exit on exit is confusing..
Better describe what it's actually doing.
src/build.sh
Outdated
| ## * `help trap` | ||
| ## | ||
| print_ok "Bind signal..." | ||
| trap exit_on_exit EXIT |
Anduin2017
approved these changes
May 13, 2025
|
Thanks for the contribution!! 感谢贡献！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
根據您在另一個討論串提到的議題。
這個「Pull Request」，加入一個「機制」，
在「製作ISO」的程式離開時，會再「
umount」一次，這樣應該可以大幅降低，在還沒有「
umount」前，就先刪除「new_building_os」的機率。您不見得要合併，
只是提供相關的程式碼，讓您了解相關的實作，
您也可以了解後，重新撰寫您自己的實作。
以上提供參考。
報告完畢。
如何測試
Ctrl + c」來中斷程式umount」的程式碼。Manpage
help trap