Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eris compat mode #1937

Merged
merged 4 commits into from
Aug 11, 2024
Merged

feat: eris compat mode #1937

merged 4 commits into from
Aug 11, 2024

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Aug 11, 2024

Adds eris compatibility

Copy link

vercel bot commented Aug 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-player-website ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2024 9:01am

@twlite
Copy link
Collaborator Author

twlite commented Aug 11, 2024

This update is now available on dev release tag and can be used like so

const { Player, createErisCompat } = require('discord-player');

const player = new Player(createErisCompat(client));

No other modifications are needed for discord-player's code.

@twlite
Copy link
Collaborator Author

twlite commented Aug 11, 2024

At the moment, voiceStateUpdate is completely ignored for compat mode due to which helpers such as leaveOnEmpty will not work. We can make it work in the future but for now playing with eris' voice state update is a pain so I have disabled it.

@twlite twlite marked this pull request as ready for review August 11, 2024 08:53
@twlite twlite merged commit fce7253 into stable Aug 11, 2024
4 checks passed
@twlite twlite deleted the eris-compat branch August 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant