fix(auth-storage): Thread safety #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
force-pushed
the
fix/thread-safe-auth-storage
branch
from
0f65044
to
01bb8ec
Compare
crocsandcoffee
approved these changes
Dec 15, 2022
...c/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorageImpl.kt
Outdated
Show resolved
Hide resolved
...c/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorageImpl.kt
Show resolved
Hide resolved
|
Ready for merge |
arkivanov
reviewed
Dec 16, 2022
...c/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorageImpl.kt
Outdated
Show resolved
Hide resolved
krizzu
commented
Dec 19, 2022
...ry/src/commonMain/kotlin/social/androiddev/common/repository/AuthenticationRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
krizzu
force-pushed
the
fix/thread-safe-auth-storage
branch
from
55ce479
to
e04cc44
Compare
krizzu
commented
Dec 19, 2022
...e/src/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorage.kt
Outdated
Show resolved
Hide resolved
crocsandcoffee
requested changes
Dec 20, 2022
...c/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorageImpl.kt
Outdated
Show resolved
Hide resolved
...e/src/commonMain/kotlin/social/androiddev/common/persistence/localstorage/DodoAuthStorage.kt
Outdated
Show resolved
Hide resolved
...ry/src/commonMain/kotlin/social/androiddev/common/repository/AuthenticationRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
...ry/src/commonMain/kotlin/social/androiddev/common/repository/AuthenticationRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
krizzu
force-pushed
the
fix/thread-safe-auth-storage
branch
from
e04cc44
to
dcc0509
Compare
|
changes reverted |
crocsandcoffee
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 What does this PR do?
Addresses #94
Making auth-storage thread safe with
mutex. Also swapping Map with LinkedMap✅ Checklist
🧪 How can this PR been tested?
🧾 Tasks Remaining: (List of tasks remaining to be implemented)
🖼️ Screenshots (if applicable):