Skip to content

Commit

Permalink
bootstd: Correct handling of script from network
Browse files Browse the repository at this point in the history
When reading a script from a network, no block device is available.
Update the implementation to support this correctly, avoiding setting
environment variables which relate only to block devices.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
  • Loading branch information
sjg20 authored and xypron committed Jul 19, 2024
1 parent cfed221 commit 60b180f
Showing 1 changed file with 31 additions and 20 deletions.
51 changes: 31 additions & 20 deletions boot/bootmeth_script.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,31 +185,42 @@ static int script_set_bootflow(struct udevice *dev, struct bootflow *bflow,

static int script_boot(struct udevice *dev, struct bootflow *bflow)
{
struct blk_desc *desc = dev_get_uclass_plat(bflow->blk);
struct blk_desc *desc;
ulong addr;
int ret = 0;

if (desc->uclass_id == UCLASS_USB) {
ret = env_set("devtype", "usb");
if (bflow->blk) {
desc = dev_get_uclass_plat(bflow->blk);
if (desc->uclass_id == UCLASS_USB) {
ret = env_set("devtype", "usb");
} else {
/*
* If the uclass is AHCI, but the driver is ATA
* (not scsi), set devtype to sata
*/
if (IS_ENABLED(CONFIG_SATA) &&
desc->uclass_id == UCLASS_AHCI)
ret = env_set("devtype", "sata");
else
ret = env_set("devtype", blk_get_devtype(bflow->blk));
}
if (!ret)
ret = env_set_hex("devnum", desc->devnum);
if (!ret)
ret = env_set_hex("distro_bootpart", bflow->part);
if (!ret)
ret = env_set("prefix", bflow->subdir);
if (!ret && IS_ENABLED(CONFIG_ARCH_SUNXI) &&
!strcmp("mmc", blk_get_devtype(bflow->blk)))
ret = env_set_hex("mmc_bootdev", desc->devnum);
} else {
/* If the uclass is AHCI, but the driver is ATA
* (not scsi), set devtype to sata
*/
if (IS_ENABLED(CONFIG_SATA) &&
desc->uclass_id == UCLASS_AHCI)
ret = env_set("devtype", "sata");
else
ret = env_set("devtype", blk_get_devtype(bflow->blk));
const struct udevice *media = dev_get_parent(bflow->dev);

ret = env_set("devtype",
uclass_get_name(device_get_uclass_id(media)));
if (!ret)
ret = env_set_hex("devnum", dev_seq(media));
}
if (!ret)
ret = env_set_hex("devnum", desc->devnum);
if (!ret)
ret = env_set_hex("distro_bootpart", bflow->part);
if (!ret)
ret = env_set("prefix", bflow->subdir);
if (!ret && IS_ENABLED(CONFIG_ARCH_SUNXI) &&
!strcmp("mmc", blk_get_devtype(bflow->blk)))
ret = env_set_hex("mmc_bootdev", desc->devnum);
if (ret)
return log_msg_ret("env", ret);

Expand Down

0 comments on commit 60b180f

Please sign in to comment.