Skip to content

Commit

Permalink
fpga: pass compatible flags to fpga_load()
Browse files Browse the repository at this point in the history
These flags may be used to check whether an FPGA driver is able to
load a particular FPGA bitstream image.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
Tested-by: Ricardo Salveti <ricardo@foundries.io>
Tested-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Link: https://lore.kernel.org/r/20220722141614.297383-7-oleksandr.suvorov@foundries.io
Signed-off-by: Michal Simek <michal.simek@amd.com>
  • Loading branch information
MrCry0 authored and michalsimek committed Jul 26, 2022
1 parent 7a9a0df commit 282eed5
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 12 deletions.
4 changes: 2 additions & 2 deletions boot/image-board.c
Original file line number Diff line number Diff line change
Expand Up @@ -705,14 +705,14 @@ int boot_get_fpga(int argc, char *const argv[], bootm_headers_t *images,
img_len, BIT_FULL);
if (err)
err = fpga_load(devnum, (const void *)img_data,
img_len, BIT_FULL);
img_len, BIT_FULL, 0);
} else {
name = "partial";
err = fpga_loadbitstream(devnum, (char *)img_data,
img_len, BIT_PARTIAL);
if (err)
err = fpga_load(devnum, (const void *)img_data,
img_len, BIT_PARTIAL);
img_len, BIT_PARTIAL, 0);
}

if (err)
Expand Down
8 changes: 4 additions & 4 deletions cmd/fpga.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ static int do_fpga_load(struct cmd_tbl *cmdtp, int flag, int argc,
if (ret)
return ret;

return fpga_load(dev, (void *)fpga_data, data_size, BIT_FULL);
return fpga_load(dev, (void *)fpga_data, data_size, BIT_FULL, 0);
}

static int do_fpga_loadb(struct cmd_tbl *cmdtp, int flag, int argc,
Expand Down Expand Up @@ -209,7 +209,7 @@ static int do_fpga_loadp(struct cmd_tbl *cmdtp, int flag, int argc,
if (ret)
return ret;

return fpga_load(dev, (void *)fpga_data, data_size, BIT_PARTIAL);
return fpga_load(dev, (void *)fpga_data, data_size, BIT_PARTIAL, 0);
}
#endif

Expand Down Expand Up @@ -315,7 +315,7 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,
data_size = image_get_data_size(hdr);
}
return fpga_load(dev, (void *)data, data_size,
BIT_FULL);
BIT_FULL, 0);
}
#endif
#if defined(CONFIG_FIT)
Expand Down Expand Up @@ -355,7 +355,7 @@ static int do_fpga_loadmk(struct cmd_tbl *cmdtp, int flag, int argc,
return CMD_RET_FAILURE;
}

return fpga_load(dev, fit_data, data_size, BIT_FULL);
return fpga_load(dev, fit_data, data_size, BIT_FULL, 0);
}
#endif
default:
Expand Down
6 changes: 4 additions & 2 deletions common/spl/spl_fit.c
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,8 @@ static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node,
{
const char *compatible;
int ret;
int devnum = 0;
int flags = 0;

debug("FPGA bitstream at: %x, size: %x\n",
(u32)fpga_image->load_addr, fpga_image->size);
Expand All @@ -591,8 +593,8 @@ static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node,
else if (strcmp(compatible, "u-boot,fpga-legacy"))
printf("Ignoring compatible = %s property\n", compatible);

ret = fpga_load(0, (void *)fpga_image->load_addr, fpga_image->size,
BIT_FULL);
ret = fpga_load(devnum, (void *)fpga_image->load_addr,
fpga_image->size, BIT_FULL, flags);
if (ret) {
printf("%s: Cannot load the image to the FPGA\n", __func__);
return ret;
Expand Down
5 changes: 3 additions & 2 deletions drivers/fpga/fpga.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ int fpga_loads(int devnum, const void *buf, size_t size,
/*
* Generic multiplexing code
*/
int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype)
int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype,
int flags)
{
int ret_val = FPGA_FAIL; /* assume failure */
const fpga_desc *desc = fpga_validate(devnum, buf, bsize,
Expand All @@ -263,7 +264,7 @@ int fpga_load(int devnum, const void *buf, size_t bsize, bitstream_type bstype)
case fpga_xilinx:
#if defined(CONFIG_FPGA_XILINX)
ret_val = xilinx_load(desc->devdesc, buf, bsize,
bstype, 0);
bstype, flags);
#else
fpga_no_sup((char *)__func__, "Xilinx devices");
#endif
Expand Down
2 changes: 1 addition & 1 deletion drivers/fpga/xilinx.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ int fpga_loadbitstream(int devnum, char *fpgadata, size_t size,
dataptr += 4;
printf(" bytes in bitstream = %d\n", swapsize);

return fpga_load(devnum, dataptr, swapsize, bstype);
return fpga_load(devnum, dataptr, swapsize, bstype, 0);
}

int xilinx_load(xilinx_desc *desc, const void *buf, size_t bsize,
Expand Down
2 changes: 1 addition & 1 deletion include/fpga.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ int fpga_count(void);
const fpga_desc *const fpga_get_desc(int devnum);
int fpga_is_partial_data(int devnum, size_t img_len);
int fpga_load(int devnum, const void *buf, size_t bsize,
bitstream_type bstype);
bitstream_type bstype, int flags);
int fpga_fsload(int devnum, const void *buf, size_t size,
fpga_fs_info *fpga_fsinfo);
int fpga_loads(int devnum, const void *buf, size_t size,
Expand Down

0 comments on commit 282eed5

Please sign in to comment.