Skip to content

Commit

Permalink
Remove including timestamp.h in version.h
Browse files Browse the repository at this point in the history
Header file version.h does not use anything from timestamp.h. Including of
timestamp.h has side effect which cause recompiling object file at every
make run because timestamp.h changes at every run.

So remove timestamp.h from version.h and include timestamp.h in files
which needs it.

This change reduce recompilation time of final U-Boot binary when U-Boot
source files were not changed as less source files needs to be recompiled.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
[trini: Add in lib/acpi/acpi_table.c and test/dm/acpi.c, rework a few others]
Signed-off-by: Tom Rini <trini@konsulko.com>
  • Loading branch information
pali authored and trini committed Sep 17, 2021
1 parent bc21ccb commit 121a165
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions arch/arm/mach-rockchip/tpl.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
#include <asm/arch-rockchip/bootrom.h>
#include <linux/bitops.h>

#if CONFIG_IS_ENABLED(BANNER_PRINT)
#include <timestamp.h>
#endif

#define TIMER_LOAD_COUNT_L 0x00
#define TIMER_LOAD_COUNT_H 0x04
#define TIMER_CONTROL_REG 0x10
Expand Down
1 change: 1 addition & 0 deletions board/work-microwave/work_92105/work_92105_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <env.h>
#include <spi.h>
#include <i2c.h>
#include <timestamp.h>
#include <version.h>
#include <vsprintf.h>
#include <linux/delay.h>
Expand Down
1 change: 1 addition & 0 deletions cmd/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <common.h>
#include <command.h>
#include <timestamp.h>
#include <version.h>
#include <version_string.h>
#include <linux/compiler.h>
Expand Down
3 changes: 3 additions & 0 deletions common/spl/spl.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
#include <nand.h>
#include <fat.h>
#include <u-boot/crc.h>
#if CONFIG_IS_ENABLED(BANNER_PRINT)
#include <timestamp.h>
#endif
#include <version.h>
#include <image.h>
#include <malloc.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/emul_rtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include <div64.h>
#include <dm.h>
#include <env.h>
#include <generated/timestamp_autogenerated.h>
#include <rtc.h>
#include <timestamp.h>

/**
* struct emul_rtc - private data for emulated RTC driver
Expand Down
2 changes: 0 additions & 2 deletions include/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#ifndef __VERSION_H__
#define __VERSION_H__

#include <timestamp.h>

#ifndef DO_DEPS_ONLY
#include "generated/version_autogenerated.h"
#endif
Expand Down
1 change: 1 addition & 0 deletions lib/acpi/acpi_table.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <log.h>
#include <mapmem.h>
#include <tables_csum.h>
#include <timestamp.h>
#include <version.h>
#include <acpi/acpi_table.h>
#include <asm/global_data.h>
Expand Down
1 change: 1 addition & 0 deletions test/dm/acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <dm.h>
#include <malloc.h>
#include <mapmem.h>
#include <timestamp.h>
#include <version.h>
#include <tables_csum.h>
#include <version.h>
Expand Down

0 comments on commit 121a165

Please sign in to comment.