Skip to content

Conversation

@AndrewBarba
Copy link
Owner

Problem

#97

Solution

Reach into undici internals to send the ping frame. Not ideal, but fixes the immediate issues

@kohenkatz
Copy link

Thanks. I'm going to have to figure out how to test this without affecting our main application where I saw the problem.

I'm curious where you got pinging every 30 seconds - the documentation I saw said to ping once an hour: https://developer.apple.com/documentation/usernotifications/sending-notification-requests-to-apns#Follow-best-practices-while-sending-push-notifications-with-APNs

@AndrewBarba
Copy link
Owner Author

I just matched what I had in fetch-http2. If 30 is too aggressive I'll up it to 5-10min

@AndrewBarba AndrewBarba merged commit 1e557b9 into main May 21, 2025
2 checks passed
@AndrewBarba AndrewBarba deleted the barba/undici-ping branch May 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants