Add pyodide build restructure #521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent flavors and seeing how the tests would be marked and etc for each version
…g ever, need to remember how I tested it locally on maocs as the wheel name is defaulting to macos currently whichis no good
…official cibuildwheel action
…se issues so I think I just have to modify the root cspice cmake a bit or this one, but hoping to just edit this project for now
…red -Wl,-soname,libcspice.wasm ' that are not being set in this repo, but those lines are only added when on unix
…s something else going on causing the shared library not to be found
…is issue in my test repo
…g kernels for tests, really should test before this push locally
…, fixed some issues with __all__
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 99.75% 99.69% -0.07%
==========================================
Files 16 15 -1
Lines 17780 17814 +34
==========================================
+ Hits 17737 17759 +22
- Misses 43 55 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…de_build_restructure
…ally should be correct in terms of rpath now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test to see if restructure of cyice is needed for #516