Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ This ESLint plugin currently contains 2 rules:

- [prefer-destructured-optionals](./docs/rules/prefer-destructured-optionals.md)
- [valid-event-listener](./docs/rules/valid-event-listener.md)
- [prefer-aliased-path](./docs/rules/prefer-aliased-path.md)
32 changes: 32 additions & 0 deletions docs/rules/prefer-aliased-path.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Suggest using a package.json alias subpath import instead of a relative import

This rule enforce to prefer using a [package.json alias subpath import](https://nodejs.org/api/packages.html#imports) path instead of a relative path, where possible.

## Examples

Given package.json:

```json
{
"name": "dummy-package-json",
"imports": {
"#helpers/*": "./src/helpers/*.ts"
}
}
```

### Fail

```js
import { myHelper } from "./src/helpers/myHelper";
```

### Pass

```js
import { myHelper } from "#helpers/myHelper";
```

```js
import { myHook } from "./hooks/myHook";
```
2 changes: 2 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import preferAliasedPath from "./rules/prefer-aliased-path";
import preferDestructuredOptionals from "./rules/prefer-destructured-optionals";
import validEventListener from "./rules/valid-event-listener";

Expand All @@ -9,6 +10,7 @@ const plugin = {
rules: {
"prefer-destructured-optionals": preferDestructuredOptionals,
"valid-event-listener": validEventListener,
"prefer-aliased-path": preferAliasedPath,
},
};

Expand Down
7 changes: 7 additions & 0 deletions src/rules/prefer-aliased-path.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@ import rule, { RULE_NAME } from "./prefer-aliased-path";

const valids = [
`import { myHelper } from "#helpers/myHelper";`,
`import myHelper from "#helpers/myHelper";`,
`import { myHelper } from "./helpers/myHelper";`,
`import { myHook } from "./hooks/myHook";`,
`import myHook from "./hooks/myHook";`,
`import { myHook } from "../hooks/myHook";`,
`import myHook from "../hooks/myHook";`,
`const myHook = require("../../hooks/myHook");`,
`const { myHook } = require("../../hooks/myHook");`,
];

const invalids = [[`import { myHelper } from "./src/helpers/myHelper";`]];
Expand Down
34 changes: 24 additions & 10 deletions src/rules/prefer-aliased-path.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { readPackageUpSync } from "read-package-up";
import { readPackageUpSync, type ReadResult } from "read-package-up";
import { minimatch } from "minimatch";
import { createEslintRule } from "../utils";

Expand Down Expand Up @@ -28,21 +28,35 @@ export default createEslintRule<Options, MessageIds>({
},
defaultOptions: [],
create(context) {
let packageJson;
const sourceCode = context.getSourceCode();

sourceCode.ast.body.some((node) => {
if (node.type === "ImportDeclaration") {
const packagePath = node.source.value;

if (packagePath.startsWith(".")) {
const currentLocalDirectory = new URL(".", import.meta.url);
packageJson = readPackageUpSync({
cwd: currentLocalDirectory,
});
}
}
if (packageJson) {
return true;
}
});

if (!packageJson?.packageJson?.imports) {
return {};
}

return {
ImportDeclaration(node) {
if (node.type === "ImportDeclaration") {
const packagePath = node.source.value;

if (packagePath.startsWith(".")) {
const currentLocalDirectory = new URL(".", import.meta.url);
const packageJson = readPackageUpSync({
cwd: currentLocalDirectory,
});

if (!packageJson?.packageJson?.imports) {
return;
}

const importAliases = Object.values(
packageJson.packageJson.imports,
);
Expand Down