Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for 1.20.5 and 1.20.6 #86

Closed
wants to merge 1 commit into from
Closed

Conversation

Kici33
Copy link

@Kici33 Kici33 commented May 20, 2024

No description provided.

@resi23
Copy link
Contributor

resi23 commented May 23, 2024

Works on Spigot but not on Paper. Paper has changed things with the craftbukkit package. Why the version query in this plugin no longer works.

papertestserver  | org.bukkit.plugin.InvalidPluginException: java.lang.ExceptionInInitializerError
papertestserver  |      at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:127) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:35) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at io.papermc.paper.plugin.entrypoint.strategy.modern.ModernPluginLoadingStrategy.loadProviders(ModernPluginLoadingStrategy.java:116) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:38) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:36) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:510) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:286) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1136) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      at java.base/java.lang.Thread.run(Unknown Source) ~[?:?]
papertestserver  | Caused by: java.lang.ExceptionInInitializerError
papertestserver  |      at images-2.3.3.jar/com.andavin.images.Versioned.<clinit>(Versioned.java:42) ~[images-2.3.3.jar:?]
papertestserver  |      at images-2.3.3.jar/com.andavin.images.Images.<clinit>(Images.java:97) ~[images-2.3.3.jar:?]
papertestserver  |      at java.base/java.lang.Class.forName0(Native Method) ~[?:?]
papertestserver  |      at java.base/java.lang.Class.forName(Unknown Source) ~[?:?]
papertestserver  |      at java.base/java.lang.Class.forName(Unknown Source) ~[?:?]
papertestserver  |      at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:78) ~[paper-api-1.20.6-R0.1-SNAPSHOT.jar:?]
papertestserver  |      at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:123) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      ... 9 more
papertestserver  | Caused by: java.lang.StringIndexOutOfBoundsException: Range [23, -1) out of bounds for length 22
papertestserver  |      at java.base/jdk.internal.util.Preconditions$1.apply(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions$1.apply(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions$4.apply(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions$4.apply(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions.outOfBounds(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Unknown Source) ~[?:?]
papertestserver  |      at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Unknown Source) ~[?:?]
papertestserver  |      at java.base/java.lang.String.checkBoundsBeginEnd(Unknown Source) ~[?:?]
papertestserver  |      at java.base/java.lang.String.substring(Unknown Source) ~[?:?]
papertestserver  |      at images-2.3.3.jar/com.andavin.util.MinecraftVersion.<clinit>(MinecraftVersion.java:170) ~[images-2.3.3.jar:?]
papertestserver  |      at images-2.3.3.jar/com.andavin.images.Versioned.<clinit>(Versioned.java:42) ~[images-2.3.3.jar:?]
papertestserver  |      at images-2.3.3.jar/com.andavin.images.Images.<clinit>(Images.java:97) ~[images-2.3.3.jar:?]
papertestserver  |      at java.base/java.lang.Class.forName0(Native Method) ~[?:?]
papertestserver  |      at java.base/java.lang.Class.forName(Unknown Source) ~[?:?]
papertestserver  |      at java.base/java.lang.Class.forName(Unknown Source) ~[?:?]
papertestserver  |      at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:78) ~[paper-api-1.20.6-R0.1-SNAPSHOT.jar:?]
papertestserver  |      at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:123) ~[paper-1.20.6.jar:1.20.6-90-b149584]
papertestserver  |      ... 9 more```

@lowercasebtw
Copy link

bump

@resi23
Copy link
Contributor

resi23 commented Jun 15, 2024

bump

https://github.com/resi23/Images/releases/tag/v2.3.3

Version 2.3.4-PaperFix works now with 1.21 Spigot AND Paper
https://github.com/resi23/Images/releases/tag/v2.3.4-PaperFix

@Andavin
Copy link
Owner

Andavin commented Jul 25, 2024

Thank you for the PR! I believe this is taken care of.

@Andavin Andavin closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants