Skip to content

Removed code that prevent mkxp from running when sound engine can't initialize #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,15 @@ int rgssThreadFun(void *userdata)

/* Setup AL context */
ALCcontext *alcCtx = alcCreateContext(threadData->alcDev, 0);

/** Not necessary, because may run on device without sound
if (!alcCtx)
{
rgssThreadError(threadData, "Error creating OpenAL context");
SDL_GL_DeleteContext(glCtx);

return 0;
}

*/
alcMakeContextCurrent(alcCtx);

try
Expand Down Expand Up @@ -295,6 +295,7 @@ int main(int argc, char *argv[])

ALCdevice *alcDev = alcOpenDevice(0);

/** Not necessary, may run on device with no sound device
if (!alcDev)
{
showInitError("Error opening OpenAL device");
Expand All @@ -305,7 +306,7 @@ int main(int argc, char *argv[])

return 0;
}

*/
SDL_DisplayMode mode;
SDL_GetDisplayMode(0, 0, &mode);

Expand Down