Extension - Fix new (spring 2024) UI buttons position #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new (spring 2024 UI), action buttons are aligned to the left but an obsolete patch made them align to the right instead. This commit removes this obsolete patch in order to restore the original alignment (left for new UI and no changes/right for the previous UI)
theblackhole
changed the title
theblackhole
changed the title
|
@theblackhole do you still experience the problem, is this patch still required? I'm hesitant about removing older code - because many people can still have that version of UI. |
|
@Anarios Unfortunately I don't have the new (spring 2024) UI anymore (I don't know why) so I can't tell if the patch is still required. But the current UI (before this big layout change) isn't affected by this patch, I think this was for an even older version of the UI |
|
@leakedmemory In your screenshot, return-youtube-dislike doesn't work at all 😅 |
|
@theblackhole Indeed, that was when I thought the bug of #1037 was not interfering with this, but I'm wrong. This still happens and that other bug too, so I'm gonna remove my other comment. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new (spring 2024) UI, action buttons are aligned to the left but an obsolete patch make them align to the right instead.
This commit removes this obsolete patch in order to restore the original alignment (left for new UI and no changes/right for the previous UI).
Tested with the new and previous UI (Firefox and Edge on Windows) with and without the ratio bar
Screenshot of the issue:
What it's supposed to look like (RYD extension disabled) :
Screenshot of the provided fix:
