Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added myself #26

Merged
merged 6 commits into from
Sep 30, 2023
Merged

Conversation

Mannxxx
Copy link
Contributor

@Mannxxx Mannxxx commented Sep 30, 2023

No description provided.

@Ananyasingh2002
Copy link
Owner

Please add your information to the HTML file.

@Ananyasingh2002 Ananyasingh2002 merged commit 36d185d into Ananyasingh2002:main Sep 30, 2023
@Mannxxx Mannxxx deleted the Mannxxx_changes branch September 30, 2023 21:44
@Mannxxx
Copy link
Contributor Author

Mannxxx commented Sep 30, 2023

Will this pull request count under hackoberfest 2023?

@Mannxxx Mannxxx restored the Mannxxx_changes branch October 2, 2023 13:15
@iammadanlal
Copy link

@Mannxxx This pull request is merged but @Ananyasingh2002 have not added label hacktoberfest-accepted on this. So most probably it is not going to be count under hacktoberfest 2023. Even if it is counted, there is a problem like here:-

PR/MRs should be useful to maintainers. Repos that encourage simplistic PR/MRs (like adding a name or profile to a list or arbitrarily curating content) will be excluded from Hacktoberfest. Remember: quantity is fun, quality is key.

By the way, I have also raised PR. Let's see what happened.

But yeah if you want 100% sure that your work is going to be under hacktoberfest. I have created three repos by following the hacktoberfest guidelines.

@iammadanlal
Copy link

@Mannxxx I have just seen the my PR on hacktoberfest and it is showing repo is excluded already.

@Mannxxx Mannxxx deleted the Mannxxx_changes branch October 5, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants