Remove query-string dependency (28% smaller bundle size)

[christianvuerings]

Description

Remove query-string dependency from calendar-link

Goal

Limit the number of dependencies to:

• improve maintainability
• reduce bundle size

File size

Approximately 28% smaller:

Before

      6.54 kB: index.modern.mjs.gz
      5.92 kB: index.modern.mjs.br
      6.55 kB: index.umd.js.gz
      5.94 kB: index.umd.js.br

After

      4.70 kB: index.modern.mjs.gz
      4.23 kB: index.modern.mjs.br
      4.70 kB: index.umd.js.gz
      4.25 kB: index.umd.js.br

Notes

In order to keep parity with previous behavior, we had to:

• Sort the keys of the object alphabetically
• Filter out null and undefined values
• Replace + with %20 in the URL to specify spaces

Apart from the filtering of null and undefined values, none of these are strictly necessary, they just made the tests pass.

Support for URLSearchParams

• Node.js >= 10: current lts version is 20.10
• 97%+ browsers: Only Opera mini / IE11 don't support it

[AnandChowdhary]

LGTM!

Maybe it's a good idea to include somewhere in the README:

This package uses URLSearchParams (Node.js >= 10, 97%+ browsers), but if you need to include a polyfill, you can include url-search-params-polyfill first.

PS: Your post on lessons learned from ChatGPT's website (especially extracting data from Next.js router's JSON page props data) was really cool!

[christianvuerings]

LGTM!

Maybe it's a good idea to include somewhere in the README:

This package uses URLSearchParams (Node.js >= 10, 97%+ browsers), but if you need to include a polyfill, you can include url-search-params-polyfill first.

Thank you for the quick review. Updated the README

[AnandChowdhary]

Thank you for your hard work!