Skip to content

Fix problems due to recent changes in pandas and yfinance.#5

Open
DangerPoodle wants to merge 2 commits into
An0n1mity:mainfrom
DangerPoodle:main
Open

Fix problems due to recent changes in pandas and yfinance.#5
DangerPoodle wants to merge 2 commits into
An0n1mity:mainfrom
DangerPoodle:main

Conversation

@DangerPoodle
Copy link
Copy Markdown

  1. Fix for pandas changes requiring use of .iloc[] and .loc[]
  2. Fix for yfinance changes involving the shape of returned dataframes and elimination of the Adj Close field.
  3. Remove some duplicated code.
  4. Added some typing info.
  5. Allow resizing the tk window so all of the tickers are visible.
  6. Suppress the yfinance progress message.
  7. Add some protection when a symbol doesn't exist (such as AUT.PA apparently)
  8. Exit cleanly when the user closes the tk window, presses escape, or hits ^C in the python window.

This PR should fix issues 3 and 4, and possibly also 1.

progress info in yf.download.  Remove duplicated code.  Allow resizing the tk
window to allow for larger symbol lists.  Add protection when a ticker
is not found by yahoo.  Exit cleanly when user presses escape, closes the
tk window, or uses ^C.  This should fix issues 3 and 4, and possibly also 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant