-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3dtiles refactor #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/gltf-parser
… in source) and loop load all scenes found
…o feature/3dtiles-gltf
…the accompanying subtree
* simple-gltf * script that optionaly reads glb from b3dm or gltf directly * load from url example and pluck glb from b3dm * log local file paths for substracted glb files ( to be able to inspect them ) * changed way of loading to more direct use of bin Load method (already in source) and loop load all scenes found * pass the source path into the loader if we use binary loading * Datasets now contain a field for the GeoLOD instead of the Unity LOD. Clarified names of LODs in tiles (#94) * public property for selected and highlighted lists * also allow public set * exposed more methods to be public * auto apply list of hidden files to new tiles appearing in child transform list (optional) * check or meshfilter * exposed method to apply hidden list * make sure metadata is loaded before we apply hide ( coming from scene or tile change the data might not be there ) * keep track of a list of interacted tiles, to minimize the amount of hide updates (when auto apply hide is enabled) * make sure FileInputIndexedDB is always on a gameobject named 'UserFileUploads', and SendMessage to that object * replaced last Share reference * added missing callback method * remove double Path Combine in case of already set path strings * remove double Path Combine in case of already set path strings (#95) * Bufix/double combine paths (#96) * remove double Path Combine in case of already set path strings * make sure to destroy create objects when stopped * removed samples removed samples * changed colors in tylesystem * added callback method for using script directly from other script and returning spawned gameobject * focus on renderer center if focus object has a renderer * optional events that are invoked * extra logging when debug mode is enabled * log stats in screen to inspect import stats in build * Bufix/double combine paths (#98) * remove double Path Combine in case of already set path strings * make sure to destroy create objects when stopped * removed samples removed samples * added callback object and method to indexeddb sync methods so they do not depend on specific object/method names * added callback object and methods for UploadFromIndexedDB (only used in 3DAms/3DUtr) * make sure to log proper method string in console * merged with main and resaved sample usage scene * moved scripts into runtime folder Co-authored-by: TomSimons <89908627+TomSimons@users.noreply.github.com> Co-authored-by: arjankoelewijn <arjan.koelewijn@utrecht.nl> Co-authored-by: arjankoelewijn <81169136+arjankoelewijn@users.noreply.github.com>
…m/Netherlands3D into feature/3dtiles
…o feature/3dtiles # Conflicts: # Assets/b3dm/Scenes/ImportB3DMGltf.unity
…loading from url can be used
…tile zoom and x y
…o feature/3dtiles
Co-authored-by: martijnvangog <69241087+martijnvangog@users.noreply.github.com>
…fig loader is used
mvriel
reviewed
Apr 13, 2023
Packages/Netherlands3D/glTFast/Runtime/Scripts/Material/ShaderGraphMaterialGenerator.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.