Feat/#58 #59
Merged
Feat/#58 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohksj77
reviewed
Oct 1, 2024
Comment on lines
94
to
101
| @Retryable(retryFor = {ObjectOptimisticLockingFailureException.class},backoff = @Backoff(value = 300L),maxAttempts = 30, recover = "temperatureRecover") | ||
| @Transactional | ||
| public TemperatureResponse decreaseTemperature(final Long groupId, final Long requestMemberId, final Long targetMemberId) { | ||
| final Participant requestParticipant = getParticipant(groupId, requestMemberId); | ||
| final Participant targetParticipant = getParticipant(groupId, targetMemberId); | ||
| return targetParticipant.downTemperature(requestParticipant); | ||
| final Integer temperature = targetParticipant.decreaseTemperature(requestParticipant); | ||
| return new TemperatureResponse(temperature); | ||
| } |
There was a problem hiding this comment.
재시도 횟수가 많기도 하지만, 가장 중요한 점은 재시도 간격이 일정하여
- 재시도 계속 발생하는 경우가 생길 수 있습니다.
- 어떤 시점에 재시도가 매우 많아져 부하가 엄청 많이 발생할 수 있을 것 같습니다.
1번의 경우 random 옵션을 활성화하여 비슷한 간격이어도 서로 다른 시각에 재시도할 수 있도록 설정할 수 있고,
2번의 경우 @backoff 의 multiplier 옵션을 활용하여 지수 백오프를 사용하여 해소할 수 있을 것 같습니다.
이렇게 설정하고 다시 테스트해보시면, 재시도 횟수를 줄여도 해소될 것으로 예상됩니다.
📝 테스트 커버리지 리포트입니다
|
📝 테스트 커버리지 리포트입니다
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
💬리뷰 요구사항