Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting/#50 #51

Merged
merged 13 commits into from
Sep 29, 2024
Merged

setting/#50 #51

merged 13 commits into from
Sep 29, 2024

Conversation

songhaechan
Copy link
Member

@songhaechan songhaechan commented Sep 24, 2024 •
edited
Loading

#️⃣연관된 이슈

ex) #50

📝작업 내용

채팅 서버 세팅, 디렉터리 구조 변경에 따른 CI/CD workflow 수정

💬리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

@songhaechan songhaechan added the setting 프로젝트를 위한 세팅 label Sep 24, 2024
@songhaechan songhaechan self-assigned this Sep 24, 2024
@songhaechan songhaechan linked an issue Sep 24, 2024 that may be closed by this pull request
setting/아모르각코 채팅서버 세팅 #50
Closed
2 tasks
ohksj77
ohksj77 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로운 서버를 추가하면서 폴더만 옮기신듯 하여 코드에 대한 피드백은 없습니다.
repository 자체를 나누는 방법도 있지만, 이렇게 동일 repository 내에 폴더만 나누신 본인만의 이유가 명확하면 됩니다.
코드를 관리하는 측면이나 배포할때 유리한지가 중요할거 같네요.

@songhaechan songhaechan merged commit 32fd05b into main Sep 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohksj77 ohksj77 ohksj77 approved these changes

Assignees

@songhaechan songhaechan

Labels
setting 프로젝트를 위한 세팅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setting/아모르각코 채팅서버 세팅
2 participants
@songhaechan @ohksj77