Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#27 #30

Merged
merged 9 commits into from
Aug 17, 2024
Merged

Feat/#27 #30

merged 9 commits into from
Aug 17, 2024

Conversation

songhaechan
Copy link
Member

#️⃣연관된 이슈

ex) #27

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요.(이미지 첨부 가능)

💬리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

@songhaechan songhaechan added the feat 기능 추가 label Aug 16, 2024
@songhaechan songhaechan self-assigned this Aug 16, 2024
@songhaechan songhaechan linked an issue Aug 16, 2024 that may be closed by this pull request
feat/rabbitmq consumer 설정, 그룹 승인/거부 api #27
Closed
2 tasks
@github-actions GitHub Actions
Copy link

📝 테스트 커버리지 리포트입니다

Overall Project 54.51% -5.57% 🍏
Files changed 47.83% 🍏

File Coverage
JwtController.java 100% 🍏
NotificationTitle.java 100% 🍏
GroupParticipationController.java 100% 🍏
NotificationController.java 100% 🍏
GroupParticipation.java 90.91% -9.09% 🍏
NotificationCreator.java 30.23% -67.44% ❌
ParticipantService.java 8.7% 🍏
JwtService.java 0% -5.97% ❌
GroupParticipationService.java 0% -61.84% ❌

ohksj77
ohksj77 reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

큰 문제는 없으나 확인해볼 항목들이 있어 우선 approve하지 않겠습니다.

...n/java/com/amorgakco/backend/groupparticipation/controller/GroupParticipationController.java Show resolved Hide resolved
...ain/java/com/amorgakco/backend/notification/infrastructure/consumer/NotificationCreator.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📝 테스트 커버리지 리포트입니다

Overall Project 54.05% -6.72% 🍏
Files changed 46.63% 🍏

File Coverage
JwtController.java 100% 🍏
NotificationTitle.java 100% 🍏
GroupParticipationController.java 100% 🍏
NotificationController.java 100% 🍏
GroupParticipation.java 90.91% -9.09% 🍏
NotificationCreator.java 28.36% -71.64% ❌
ParticipantService.java 8.7% 🍏
JwtService.java 0% -5.97% ❌
GroupParticipationService.java 0% -61.84% ❌

@songhaechan songhaechan merged commit 17183d9 into main Aug 17, 2024
1 check passed
songhaechan added a commit that referenced this pull request Sep 21, 2024
@songhaechan
Merge pull request #30 from AmorGakCo/feat/#27
9a4a490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohksj77 ohksj77 ohksj77 left review comments

Assignees

@songhaechan songhaechan

Labels
feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat/rabbitmq consumer 설정, 그룹 승인/거부 api
2 participants
@songhaechan @ohksj77