Skip to content

Merging animations doesn't work #42

Open
@AmoebeLabs

Description

Bug description

Merging animations doesn't seem to work. See also #41
This happens only with the switch tool, as this one defines default animations.

Problem is caused by:

  • The mergeDeep() function concatenates arrays
  • The function that handles the defined animations to define the style stops when the first match is found.

(Optional): Suggested Solution

This problem can be solved at two locations:

  • let mergeDeep() check for id's in the array, and merge by id. This means that animations should have an id.
    This solutions is generic, and could be used for more arrays...
  • let the set value() function that handles the animation continue looking for a match in the animations array, and merge each occurrence in the array.

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions