mkdir() was causing a DSI when directory had a '/' at the end

.github/workflows/_compile.yml

@@ -20,10 +20,15 @@ on:
 
 env:
   archive_name: clib4-${{ inputs.git_tag }}${{ inputs.spe == 'yes' && '_SPE' || '' }}
+  SSH_KEY: ${{ secrets.DEBSERVER_PRIVATE_KEY }}
+  SSH_USER: ${{ secrets.DEBSERVER_USERNAME }}
+  SSH_PORT: ${{ secrets.DEBSERVER_PORT }}
+  SSH_HOST: ${{ secrets.DEBSERVER_HOST }}
 
 jobs:
   compile:
     runs-on: ubuntu-latest
+    environment: deploy_environment
     container:
       image: walkero/amigagccondocker:os4-gcc${{ inputs.gcc }}
       volumes:
@@ -75,19 +80,50 @@ jobs:
           asset_name: ${{ env.archive_name }}_amd64.deb
           asset_content_type: application/vnd.debian.binary-pac
 
-      - name: Upload DEB release file to the server
-        uses: kostya-ten/ssh-server-deploy@v4
-        with:
-          host: ${{ secrets.DEBSERVER_HOST }}
-          port: ${{ secrets.DEBSERVER_PORT }}
-          username: ${{ secrets.DEBSERVER_USERNAME }}
-          private_key: ${{ secrets.DEBSERVER_PRIVATE_KEY }}
-          scp_source: /opt/code/${{ env.archive_name }}_amd64.deb
-          scp_target: /opt/amigarepo/ubuntu/pool/main
-          before_script: |
-            rm /opt/amigarepo/ubuntu/pool/main/clib4-*_amd64.deb
-          after_script: |
-            /root/regenerate-packages.sh
+      - name: Install SSH client
+        run: sudo apt-get update && sudo apt-get install -y openssh-client
+
+      - name: Setup SSH key
+        if: ${{ inputs.spe == 'no' }}
+        run: |
+          mkdir -p ~/.ssh
+          echo "$SSH_KEY" > ~/.ssh/id_rsa
+          chmod 600 ~/.ssh/id_rsa
+          ssh-keyscan -p $SSH_PORT -H $SSH_HOST >> ~/.ssh/known_hosts
+
+      - name: Before script
+        if: ${{ inputs.spe == 'no' }}
+        run: |
+          echo "Remove old release"
+          ssh -i ~/.ssh/id_rsa \
+              -p $SSH_PORT \
+              -o StrictHostKeyChecking=no \
+              $SSH_USER@$SSH_HOST \
+              "rm /opt/amigarepo/ubuntu/pool/main/clib4-v*_amd64.deb"
+
+      - name: Upload via SCP
+        if: ${{ inputs.spe == 'no' }}
+        run: |
+          scp -i ~/.ssh/id_rsa \
+              -P $SSH_PORT \
+              -o StrictHostKeyChecking=no \
+              "/opt/code/${{ env.archive_name }}_amd64.deb" \
+              $SSH_USER@$SSH_HOST:/opt/amigarepo/ubuntu/pool/main
+
+      - name: After script
+        if: ${{ inputs.spe == 'no' }}
+        run: |
+          echo "Regenerate the packages"
+          ssh -i ~/.ssh/id_rsa \
+              -p $SSH_PORT \
+              -o StrictHostKeyChecking=no \
+              $SSH_USER@$SSH_HOST \
+              "sh /root/regenerate-packages.sh"
+
+      - name: SSH Cleanup
+        if: ${{ inputs.spe == 'no' }}
+        run: |
+          rm -f ~/.ssh/id_rsa
 
       - name: Create Pull Request
         if: ${{ inputs.spe == 'no' }}

.github/workflows/makeRelease.yml

@@ -15,6 +15,8 @@ jobs:
       git_tag: ${{ github.event.release.tag_name }}
       gcc: 11
       spe: "no"
+    secrets: inherit
+
 
   compile-spe:
     name: Build for PowerPC SPE cpus
@@ -23,6 +25,7 @@ jobs:
       git_tag: ${{ github.event.release.tag_name }}
       gcc: 6
       spe: "yes"
+    secrets: inherit
 
   announcements:
     needs: [compile-ppc, compile-spe]

library/c.lib_rev.h

@@ -1,8 +1,8 @@
-#define VERSION			1
-#define REVISION		6
+#define VERSION			2
+#define REVISION		0
 #define SUBREVISION		0
 
-#define DATE			"28.04.2025"
-#define VERS			"clib4.library 1.6.0"
-#define VSTRING			"clib4.library 1.6.0 (28.04.2025)\r\n"
-#define VERSTAG			"\0$VER: clib4.library 1.6.0-da4edaa (28.04.2025)"
+#define DATE			"16.08.2025"
+#define VERS			"clib4.library 2.0.0"
+#define VSTRING			"clib4.library 2.0.0 (16.08.2025)\r\n"
+#define VERSTAG			"\0$VER: clib4.library 2.0.0-ab40f98 (16.08.2025)"

library/stat/mkdir.c

@@ -41,15 +41,17 @@ int mkdir(const char *path_name, mode_t mode) {
         }
     }
 
-    char *path_to_create = (char *) path_name;
+    char path_to_create[PATH_MAX] = {0};
+    strncpy(path_to_create, path_name, PATH_MAX - 1);
 
     /* This check avoid that for some mistakes a directory contain more than one : char inside the name
      * This could help to avoid problems on SFS file system that allow (by mistake) the creation of dirs
      * like DriveName:Dir/DriveName:Dir
      */
 
     int counter = 0;
-    for (int i = 0; path_to_create[i]; i++) {
+    size_t len = strlen(path_to_create);
+    for (size_t i = 0; i < len; i++) {
         if (path_to_create[i] == ':') {
             counter++;
         }
@@ -61,7 +63,6 @@ int mkdir(const char *path_name, mode_t mode) {
         goto out;
     }
 
-    size_t len = strlen(path_to_create);
     if (path_to_create[len - 1] == '/') {
         path_to_create[len - 1] = '\0'; // Remove '/' if present
     }

misc/control

@@ -1,5 +1,5 @@
 Package: amigaos4-clib4
-Version: 1.6.0
+Version: 2.0.0
 Maintainer: Andrea Palmatè <os4test@amigasoft.net>
 Architecture: amd64
 Section: libdevel