Split stubs #233
Merged
Split stubs #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the libc.gmk file to consider them
…reparing a list of stubs_ files.
|
We need to wtite something on doc to handle the latest function pointer offset to be sure that no other stub has the same address and it is always +4 |
|
What was the outcome of the binaries you tested? Was the final size much smaller, close to what newlib has? |
walkero-gr
approved these changes
Dec 23, 2024
|
George. Yes, similar size to newlib.
…On Mon, 23 Dec 2024, 16:54 Andrea Palmatè, ***@***.***> wrote:
Merged #233 <#233> into
development.
—
Reply to this email directly, view it on GitHub
<#233 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNDARP3I7LIVACXEYHSB5L2HA55ZAVCNFSM6AAAAABUBYLHY2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG42TAMJRGYYDAMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #229
I have tried to build a cross compiler using the "split_stubs" branch and it was successful. I built all the tests (ignoring failures that exist on "development" anyway). I executed the test on the AmigaOne machine and it ran okay.
More testing would be good, this PR is just for review. One issue that all stubs pull in a stubs_common.o file.
Anyway, here is an initial PR.