Skip to content

Conversation

@elfpipe
Copy link
Collaborator

@elfpipe elfpipe commented Aug 27, 2024

There were different mistakes in the code, making it impossible for waitpid to find the return code element in the children hashmap.

  1. uuid4_generate would not properly seed the random state, so it would return the same uuid repeatedly.

  2. spawnedProcessExit and insertSpawned children would do a mish-mash of parent and child pids, so the search/insertion would fail.

  3. WEXITSTATUS would do an unnecessary shift, resulting in the wrong return code.

@afxgroup
Copy link
Collaborator

Can we remove spawnve_callback from functions list and use it for something else? I think no one is using it at moment so I don't think it is a big deal. We can add a void *unused or something similar and add the next function there

@elfpipe
Copy link
Collaborator Author

elfpipe commented Aug 28, 2024

Yes, I think we can remove spawnvpe_callback. It is a beautiful construct, but I don't think it is useful for anything at this point. So we can use the space for something else.

@afxgroup
Copy link
Collaborator

So can you change the interface and stubs and commit?

@elfpipe
Copy link
Collaborator Author

elfpipe commented Aug 28, 2024

Done.

@afxgroup afxgroup merged commit d578533 into AmigaLabs:beta10 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants