Tests for GET /v5/channel/list and multichain support#479
Merged
simzzz merged 9 commits intoaip-61-adex-v5from Mar 28, 2022
Merged
Tests for GET /v5/channel/list and multichain support#479simzzz merged 9 commits intoaip-61-adex-v5from
simzzz merged 9 commits intoaip-61-adex-v5from
Conversation
elpiel
suggested changes
Mar 18, 2022
Contributor
elpiel
left a comment
elpiel
left a comment
There was a problem hiding this comment.
Minor things only, good job 😋
21 tasks
elpiel
changed the title
elpiel
suggested changes
Mar 28, 2022
Contributor
elpiel
left a comment
elpiel
left a comment
There was a problem hiding this comment.
- Fix the conflicting file
- One test is failing because we've added the 0x000 address to config, you can change it to 00..1 until I deploy a new contract on a new Chain Id in ganache.
elpiel
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.