Issue 382 Remove V4 Channel and fns cleanup#435
Merged
elpiel merged 10 commits intoaip-61-adex-v5from Sep 28, 2021
Merged
Conversation
- primitives - remove V4 Channel - Config - remove unused values & add update with analytics - sentry - remove old V4 Channel routes
21 tasks
- Adapter & error imporvements in adapters
elpiel
changed the title
- adapter - remove tokio-compat-02 - primitives - move once_cell from dev deps to deps
- use once_cell::sync::Lazy - fix typo in config attribute
elpiel
force-pushed
the
issue-382-old-channel-and-fns-cleanup
branch
from
3459c11 to
9694de8
Compare
simzzz
suggested changes
Sep 27, 2021
Contributor
simzzz
left a comment
simzzz
left a comment
There was a problem hiding this comment.
LGTM just a few use statements and function names that could be changed
elpiel
force-pushed
the
issue-382-old-channel-and-fns-cleanup
branch
from
dcac2b3 to
b32d221
Compare
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes a task in #382
tokio compatcrate