Skip to content

AIP#61 AdEx V5: Targeting rules use UnifiedNum#412

Merged
elpiel merged 12 commits intoaip-61-adex-v5from
aip61-targeting-rules-use-unified-num
Jun 25, 2021
Merged

AIP#61 AdEx V5: Targeting rules use UnifiedNum#412
elpiel merged 12 commits intoaip-61-adex-v5from
aip61-targeting-rules-use-unified-num

Conversation

@elpiel
Copy link
Contributor

@elpiel elpiel commented Jun 18, 2021

No description provided.

@elpiel elpiel mentioned this pull request Jun 18, 2021
4 tasks
@elpiel elpiel changed the base branch from master to aip-61-adex-v5 June 18, 2021 06:50
@elpiel elpiel changed the title AIP#61 AdEx V5: Targeting rules use unified num AIP#61 AdEx V5: Targeting rules use UnifiedNum Jun 18, 2021
@elpiel elpiel requested a review from simzzz June 18, 2021 11:10
@elpiel elpiel marked this pull request as ready for review June 18, 2021 11:10
@elpiel elpiel requested a review from samparsky June 18, 2021 11:10
@@ -234,7 +234,7 @@ pub fn get_unit_html_with_events(
.map(|validator| {
let fetch_url = format!(
"{}/channel/{}/events?pubAddr={}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed when the events route for a Campaign is updated, see tasks for #382

@elpiel elpiel merged commit d45f0cf into aip-61-adex-v5 Jun 25, 2021
@simzzz simzzz mentioned this pull request Jun 25, 2021
21 tasks
@elpiel elpiel deleted the aip61-targeting-rules-use-unified-num branch August 12, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants