Skip to content

refactor: don't wait for domReady #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeidahmed merged 1 commit into from
Aug 24, 2024
Merged

refactor: don't wait for domReady #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/core/src/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import Action from './action';
import type { PropertyConstructor, PropertyType } from './decorators/property';
import { domReady } from './helpers/dom';
import { camelize, dasherize, parseJSON } from './helpers/string';
import Property from './property';
import Store from './store';
Expand All @@ -13,7 +12,6 @@ export default class ImpulseElement extends HTMLElement {
private _started = false;

async connectedCallback() {
await domReady();
customElements.upgrade(this);
// Order is important
this.property.start();
Expand Down Expand Up @@ -97,10 +95,10 @@ export default class ImpulseElement extends HTMLElement {
return this.tagName.toLowerCase();
}

private async _resolveUndefinedElements() {
private _resolveUndefinedElements() {
const undefinedElements = Array.from(this.querySelectorAll(':not(:defined)'));
const promises = undefinedElements.map((element) => customElements.whenDefined(element.localName));
await Promise.all(promises);
return Promise.all(promises);
}
}

Expand Down