change: invoke disconnected before [target]Disconnected
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, we made the decision to invoke the `disconnected` function before invoking the `[target]Disconnected` function. This is because, our apps have a tendency to clean up and refer targets within the `disconnected` function, and if we disconnect targets before the element itself, we get a null/undefined exception error and have to do safety checks manually.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we decided to invoke the
disconnectedfunction before invoking the[target]Disconnectedfunction. Our apps tend to clean up and refer targets within thedisconnectedfunction. If we disconnect targets before the element itself, we get a null/undefined exception error and have to do safety checks manually.