Merged
Conversation
philpax
approved these changes
Sep 12, 2023
docs/src/reference/hierarchies.md
Outdated
|
|
||
| ## Opting out of automatically derived children | ||
|
|
||
| If you whish to manage the `children` component yourself, you can attach an `unmanaged_children` component to your |
guest/rust/api_core/src/entity.rs
Outdated
| children.retain(|x| *x != child) | ||
| }); | ||
| if has_component(entity, unmanaged_children()) { | ||
| if has_component(entity, children()) { |
Contributor
There was a problem hiding this comment.
this if not necessary, mutate_component does nothing if it doesn't have that component
Contributor
Author
There was a problem hiding this comment.
@philpax Hm yeah, it feels like the mutate_component etc. should return Results, so it's up to the user to handle situations like that? Then it could just be .ok() on it to ignore the result.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes client-server synchronization of hierarchies; instead of synchronizing the
childrenwe now only synchronizeparentand instead constructchildrenbased on parents. (Re. #843 )