feat(primitives): New torus primitive #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
May 9, 2023
There was a problem hiding this comment.
Thanks for your contribution! I left some comments that you might want to double check.
Also, do you mind running golden image tests and update the corresponding golden image under primitives example? Instructions: https://github.com/AmbientRun/Ambient/blob/main/docs/src/community/contributing.md#golden-image-tests
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitives : Torus !
adds a new torus concept, along with the internal classe TorusMesh along with the specific torus components such as torus_inner_radius, etc
adds Torus accessibility to the client
also adds a torus entity in the guest/rust/examples/basics/primitives demo project