Add Dump UI World button and remap hotkeys #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpalmer
force-pushed
the
main
branch
2 times, most recently
from
f193e73
to
808b99f
Compare
| @@ -610,9 +609,7 @@ impl System<Event<'static, ()>> for ExamplesSystem { | |||
| }, | |||
| .. | |||
| } => match virtual_keycode { | |||
There was a problem hiding this comment.
So these are actually used in the "native" examples, which doesn't have a Debugger. I'll merge and just revert that part
There was a problem hiding this comment.
Okay that makes a lot more sense, thank you!
|
@owenpalmer Merged. Thanks for the PR! |
|
Happy to help! |
philpax
pushed a commit
that referenced
this pull request
May 23, 2023
Add Dump UI World button and remap hotkeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193.
There was a bug that prevented
hotkey_modifierfrom working, the modifiers weren't being set in the keyboard event.I decided not to implement the write_debug function in this commit since I would rather not involve it in a minor feature such as this.