Optimisations and improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to not rely on api if they are in the path name
Amateur-God
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8
closes #8
resolves #9
closes #9
Improved functionality of the Favourite handling, it now handles TV shows and movies separately and it now adds the series name to blacklisted TV Shows and movie Name to blacklisted movies along with the path to blacklisted paths for both, this wasn't necessary but was added as a fallback.
Added IGNORE_FAVOURITES as an env variable so people can set this to false if they want to disable the script ignoring/blacklisting favourites (Default behavior is true)
Improved the functions to get TVDB and TMDBID which are used by sonarr/radarr functions to find the correct show/movie, it will now check the items path for tvdbid-Number and tmdbid-Number which if you are following the recommended naming guides and are using sonarr/radarr to rename them then these should be found in the path, however if these aren't found in the path it will fallback to calling the TVDB and TMDB APIs to query them for the ID.
This was done to limit the possibility of getting the wrong ID and to limit the number of API calls made to TVDB and TMDB