Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schematics cache #76

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: schematics cache #76

merged 1 commit into from
Feb 9, 2023

Conversation

cpaulve-1A
Copy link
Contributor

Remove incorrect outputs and dependency on project.json

Only package with non standard structure should have custom outputs and dependsOn properties

Remove the reference in o3r/styling/tsconfig.builders.json to the src folder (composite build)

o3r/styling builders have a dependency over the compiled package and should not try to compile it themselves

@cpaulve-1A cpaulve-1A requested a review from a team as a code owner February 7, 2023 15:38
@cpaulve-1A cpaulve-1A temporarily deployed to development February 7, 2023 15:48 — with GitHub Actions Inactive
jbourgeois-1A
jbourgeois-1A previously approved these changes Feb 7, 2023
@cpaulve-1A cpaulve-1A force-pushed the fixup/schematics-cache branch 2 times, most recently from dac1b8f to ace4c0e Compare February 7, 2023 16:13
nx.json Show resolved Hide resolved
nx.json Outdated Show resolved Hide resolved
nx.json Outdated Show resolved Hide resolved
@cpaulve-1A cpaulve-1A temporarily deployed to development February 7, 2023 16:24 — with GitHub Actions Inactive
Remove incorrect outputs and dependency on project.json

Only package with non standard structure should have custom outputs and dependsOn properties

Remove the reference in o3r/styling/tsconfig.builders.json to the src folder (composite build)

o3r/styling builders have a dependency over the compiled package and should not try to compile it themselves
@cpaulve-1A cpaulve-1A force-pushed the fixup/schematics-cache branch from ace4c0e to 17f1939 Compare February 7, 2023 16:54
@cpaulve-1A cpaulve-1A temporarily deployed to development February 7, 2023 17:04 — with GitHub Actions Inactive
@cpaulve-1A cpaulve-1A merged commit 8da4a54 into main Feb 9, 2023
@cpaulve-1A cpaulve-1A deleted the fixup/schematics-cache branch February 9, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants