Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: align typescript-eslint deps #2787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: align typescript-eslint deps #2787

wants to merge 1 commit into from
+8 −69

Conversation

vscaiceanu-1a
Copy link
Member

Proposed change

Align some deps

@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner February 3, 2025 13:33
@vscaiceanu-1a vscaiceanu-1a force-pushed the chore/align-tseslint-deps branch from ccb84d5 to 43bd7c9 Compare February 3, 2025 13:49
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit be3522e.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 6m 17s View ↗
nx run-many --target=test-e2e ✅ Succeeded 8m 43s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 34s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 16s View ↗
nx affected --target=lint ✅ Succeeded 16m 30s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 13m 13s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 11m 18s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 15:35:40 UTC

@vscaiceanu-1a vscaiceanu-1a force-pushed the chore/align-tseslint-deps branch from 43bd7c9 to be3522e Compare February 3, 2025 14:00
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (acd5258) to head (be3522e).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpaulve-1A
cpaulve-1A reviewed Feb 3, 2025
View reviewed changes
.yarnrc.yml
@@ -16,7 +16,7 @@ packageExtensions:
"@swc/types": "*"
"@typescript-eslint/rule-tester@*":
dependencies:
"@typescript-eslint/parser": ~8.21.0
"@typescript-eslint/parser": ~8.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to enforce it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still only in its devDependencies so I would say yes if we are using typings from @typescript-eslint/parser.

kpanot
kpanot approved these changes Feb 4, 2025
View reviewed changes
.yarnrc.yml
@@ -16,7 +16,7 @@ packageExtensions:
"@swc/types": "*"
"@typescript-eslint/rule-tester@*":
dependencies:
"@typescript-eslint/parser": ~8.21.0
"@typescript-eslint/parser": ~8.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still only in its devDependencies so I would say yes if we are using typings from @typescript-eslint/parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulve-1A cpaulve-1A cpaulve-1A left review comments

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@kpanot kpanot kpanot approved these changes

Assignees
No one assigned
Labels
project:@ama-sdk/schematics project:@o3r/core project:@o3r/eslint-config project:@o3r/eslint-config-otter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vscaiceanu-1a @kpanot @fpaul-1A @cpaulve-1A