Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(training): missing dependencies #2785

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(training): missing dependencies #2785

merged 1 commit into from
Feb 4, 2025

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Feb 3, 2025

Proposed change

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner February 3, 2025 10:46
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit aa480af.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 2m 37s View ↗
nx run-many --target=test-e2e ✅ Succeeded 10m 20s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 34s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 15s View ↗
nx affected --target=lint ✅ Succeeded 15m 17s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 11m 52s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 14m 1s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 12:41:27 UTC

sdo-1A
sdo-1A previously approved these changes Feb 3, 2025
View reviewed changes
@fpaul-1A fpaul-1A force-pushed the fix/training-dependencies branch from 70b163b to 83a1654 Compare February 3, 2025 10:58
@fpaul-1A fpaul-1A force-pushed the fix/training-dependencies branch from 83a1654 to aa480af Compare February 3, 2025 11:08
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (acd5258) to head (aa480af).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vscaiceanu-1a
vscaiceanu-1a reviewed Feb 3, 2025
View reviewed changes
apps/showcase/src/app/app.module.ts
@@ -197,7 +198,8 @@ export function registerCustomComponents(): Map<string, any> {
markedExtensions: [markedAlert()],
/* Templates are only internal, no need to sanitize */
sanitize: SecurityContext.NONE
})
}),
{ provide: NGX_MONACO_EDITOR_CONFIG, useValue: { baseUrl: `${location.origin}${location.pathname}assets/monaco/min/vs` } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ provide: NGX_MONACO_EDITOR_CONFIG, useValue: { baseUrl: `${location.origin}${location.pathname}assets/monaco/min/vs` } }
{ provide: NGX_MONACO_EDITOR_CONFIG, useValue: { baseUrl: `${location.href}/assets/monaco/min/vs` } }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I don't want the full location.href here
location.href = 'https://amadeusitgroup.github.io/otter/#/sdk-training#0'
location.origin = 'https://amadeusitgroup.github.io'
location.pathname = '/otter/'

what I want is https://amadeusitgroup.github.io/otter/assets/monaco/min/vs

@fpaul-1A fpaul-1A added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit fa6768b Feb 4, 2025
37 checks passed
@fpaul-1A fpaul-1A deleted the fix/training-dependencies branch February 4, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscaiceanu-1a vscaiceanu-1a vscaiceanu-1a left review comments

@kpanot kpanot kpanot approved these changes

@cpaulve-1A cpaulve-1A cpaulve-1A approved these changes

@sdo-1A sdo-1A sdo-1A left review comments

Assignees
No one assigned
Labels
bug Something isn't working project:@ama-sdk/schematics project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/core project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/showcase project:release-gh-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fpaul-1A @kpanot @vscaiceanu-1a @cpaulve-1A @sdo-1A