Merge main to otter training #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed change use posix to compute path for `outputPath` ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> <!-- * 🐛 Fix #issue --> * 🐛 Fix resolves #2630 <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
## Proposed change chore: add auto generated yarn ignored files <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change As a developer I want to be able to flag a configuration property as sensitive. It was decided to have an array of restriction, named `restrictionKeys` for each property, to support potential future use case with different level of restriction based on the role of the user configuring the property value. This PR includes: - the update of the metadata schema - the extraction of `restrictionKeys` from the jsdoc tags `@o3rRestrictionKeys` - a linter to limit the possible keys used with `@o3rRestrictionKeys` ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change Renovate missed some deps in #2617 Fixing them here. <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
## Proposed change fix: eslint and nx ignored paths <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`~8.18.0` -> `~8.19.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.18.1/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`~8.18.0` -> `~8.19.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.18.1/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/rule-tester](https://typescript-eslint.io/packages/rule-tester) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/rule-tester)) | [`~8.18.0` -> `~8.19.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2frule-tester/8.18.1/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/utils](https://typescript-eslint.io/packages/utils) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/utils)) | [`~8.18.0` -> `~8.19.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2futils/8.18.1/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript-eslint](https://typescript-eslint.io/packages/typescript-eslint) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint)) | [`~8.18.0` -> `~8.19.0`](https://renovatebot.com/diffs/npm/typescript-eslint/8.18.1/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v8.19.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.2...v8.19.0) ##### 🚀 Features - **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#​10106](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10106)) ##### 🩹 Fixes - **eslint-plugin:** \[member-ordering] ignore method overloading ([#​10536](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10536)) - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#​10537](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10537)) - **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#​10522](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10522)) - **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#​10496](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10496)) ##### ❤️ Thank You - Karl Werner - Kirk Waiblinger [@​kirkwaiblinger](https://redirect.github.com/kirkwaiblinger) - Ronen Amiel - YeonJuan [@​yeonjuan](https://redirect.github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.18.2`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.1...v8.18.2) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#​10514](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10514)) - **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#​10512](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10512)) - **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#​10503](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10503)) - **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#​10461](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10461)) - **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#​10490](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10490)) - **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#​10473](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10473)) - **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#​10494](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10494)) - **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#​10498](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10498)) ##### ❤️ Thank You - Luke Deen Taylor [@​controversial](https://redirect.github.com/controversial) - Ronen Amiel - Scott O'Hara - YeonJuan [@​yeonjuan](https://redirect.github.com/yeonjuan) - Yukihiro Hasegawa [@​y-hsgw](https://redirect.github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v8.19.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8190-2024-12-30) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.2...v8.19.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.18.2`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8182-2024-12-23) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.1...v8.18.2) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/rule-tester)</summary> ### [`v8.19.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/rule-tester/CHANGELOG.md#8190-2024-12-30) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.2...v8.19.0) This was a version bump only for rule-tester to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.18.2`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/rule-tester/CHANGELOG.md#8182-2024-12-23) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.1...v8.18.2) This was a version bump only for rule-tester to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/utils)</summary> ### [`v8.19.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/utils/CHANGELOG.md#8190-2024-12-30) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.2...v8.19.0) ##### 🩹 Fixes - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#​10537](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10537)) ##### ❤️ Thank You - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.18.2`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/utils/CHANGELOG.md#8182-2024-12-23) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.1...v8.18.2) This was a version bump only for utils to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (typescript-eslint)</summary> ### [`v8.19.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8190-2024-12-30) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.2...v8.19.0) This was a version bump only for typescript-eslint to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.18.2`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8182-2024-12-23) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.18.1...v8.18.2) ##### 🩹 Fixes - **typescript-eslint:** export types so that declarations can be named for dts files ([#​10513](https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10513)) ##### ❤️ Thank You - Brad Zacher [@​bradzacher](https://redirect.github.com/bradzacher) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/AmadeusITGroup/otter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44NS4wIiwidXBkYXRlZEluVmVyIjoiMzkuODUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [yarn](https://redirect.github.com/yarnpkg/berry) ([source](https://redirect.github.com/yarnpkg/berry/tree/HEAD/packages/yarnpkg-cli)) | [`4.5.3` -> `4.6.0`](https://renovatebot.com/diffs/npm/yarn/4.5.3/4.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>yarnpkg/berry (yarn)</summary> ### [`v4.6.0`](https://redirect.github.com/yarnpkg/berry/compare/2fe7d635e8eb163c1b3e56ab76e652b6bae8c160...1871484db82161065ac437d4df59bc8a4f94a33e) [Compare Source](https://redirect.github.com/yarnpkg/berry/compare/2fe7d635e8eb163c1b3e56ab76e652b6bae8c160...1871484db82161065ac437d4df59bc8a4f94a33e) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/AmadeusITGroup/otter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44NS4wIiwidXBkYXRlZEluVmVyIjoiMzkuODUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
## Proposed change chore: dependency alignment <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
|
View your CI Pipeline Execution ↗ for commit c86a9f6.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
bug
github-actions
bot
added
project:@o3r/github-cascading-app
project:@o3r/localization
project:@o3r/logger
project:@o3r/mobile
project:@o3r/new-version
project:@o3r/pipeline
project:@o3r/routing
project:@o3r/rules-engine
project:@o3r/schematics
project:@o3r/showcase
project:@o3r/store-sync
project:@o3r/storybook
project:@o3r/stylelint-plugin
project:@o3r/styling
project:@o3r/telemetry
project:@o3r/test-helpers
project:@o3r/testing
project:@o3r/third-party
project:@o3r/workspace
project:@o3r/workspace-helpers
project:audit-gh-action
project:cascading-gh-action
project:get-npm-tag-gh-action
project:new-version-gh-action
project:otter-devtools
project:release-gh-action
labels
matthieu-crouzet
approved these changes
Jan 6, 2025
sdo-1A
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Conflicting files
.vscode/settings.json
.yarnrc.yml
package.json
packages/@ama-sdk/schematics/package.json
packages/@o3r/core/package.json
packages/@o3r/eslint-config-otter/package.json
yarn.lock
Related issues
- No issue associated -