[extension/awsproxy] awsproxy extension adopts `component.UseLocalHos…

…tAsDefaultHost` feature gate (open-telemetry#30985) Description: awsproxy extension adopts `component.UseLocalHostAsDefaultHost` feature gate Link to tracking Issue: open-telemetry#30702 Fixes open-telemetry#30984 Documentation: Updated docs. Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
AmadeusITGroup · Feb 1, 2024 · f605ed9 · f605ed9
1 parent 9f4ad54
commit f605ed9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.chloggen/mx-psi_internal-localhostgate.yaml b/.chloggen/mx-psi_internal-localhostgate.yaml
@@ -27,6 +27,7 @@ subtext: |
     - receiver/influxdb
     - receiver/zookeeper
     - receiver/signalfx
+    - extension/awsproxy
     - receiver/sapm
     - extension/jaegerremotesampling
     - receiver/jaeger

diff --git a/extension/awsproxy/README.md b/extension/awsproxy/README.md
@@ -42,6 +42,9 @@ The TCP address and port on which this proxy listens for requests.
 
 Default: `0.0.0.0:2000`
 
+The `component.UseLocalHostAsDefaultHost` feature gate changes this to localhost:2000. This will become the default in a future release.
+
+
 ### proxy_address (Optional)
 Defines the proxy address that this extension forwards HTTP requests to the AWS backend through. If left unconfigured, requests will be sent directly.
 This will generally be set to a NAT gateway when the collector is running on a network without public internet.

diff --git a/extension/awsproxy/factory.go b/extension/awsproxy/factory.go
@@ -13,10 +13,11 @@ import (
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsproxy/internal/metadata"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/proxy"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/localhostgate"
 )
 
 const (
-	defaultEndpoint = "0.0.0.0:2000"
+	defaultPort = 2000
 )
 
 // NewFactory creates a factory for awsproxy extension.
@@ -33,7 +34,7 @@ func createDefaultConfig() component.Config {
 	return &Config{
 		ProxyConfig: proxy.Config{
 			TCPAddr: confignet.TCPAddr{
-				Endpoint: defaultEndpoint,
+				Endpoint: localhostgate.EndpointForPort(defaultPort),
 			},
 			TLSSetting: configtls.TLSClientSetting{
 				Insecure: false,

diff --git a/extension/awsproxy/factory_test.go b/extension/awsproxy/factory_test.go
@@ -28,7 +28,7 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
 	assert.Equal(t, &Config{
 		ProxyConfig: proxy.Config{
 			TCPAddr: confignet.TCPAddr{
-				Endpoint: defaultEndpoint,
+				Endpoint: "0.0.0.0:2000",
 			},
 		},
 	}, cfg)