Rendering checkboxes summary as string, when string is provided #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when showing a summary, but SummaryComponentSwitch.tsx assumed checkboxes always got a list of choices. When formData is string, we'll do the safe thing and just render that string. Otherwise each character in that string will be iterated.
|
Kudos, SonarCloud Quality Gate passed! |
haakemon
reviewed
Jul 1, 2022
| @@ -468,3 +469,11 @@ export function isDatePickerComponent( | |||
| ): component is IDatePickerProps & ILayoutComponent { | |||
| return component.type.toLowerCase() === 'datepicker'; | |||
| } | |||
|
|
|||
| export function isCheckboxesComponent( | |||
There was a problem hiding this comment.
Yup, I can do that, but I prefer to do it in a later PR. There are some changes to these functions in the hackaton/dynamics branch which I'd like to port over, and I've thought about possibly changing up some of the typings. The component types are a prime example of a case where discriminated unions works wonders - so with a change in that direction, these functions could be removed altogether, as TypeScript would give us the same functionality out of the box. I'll add it to my list of sabbatical TODOs.. 😉
haakemon
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The summary page could end up rendering
Checkboxescomponents by iterating each character and listing them line-by-line. This happens when theformDatais provided as a string.This quick-fix just renders the string instead, but we could also go the extra mile by hunting down why this happens and make sure
Checkboxescomponents are always summarized with list inputs - although it is stored informDataas a comma-separated string.Related Issue(s)
Verification
Documentation
[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)