Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up unused saga actions #304

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Cleaning up unused saga actions #304

merged 5 commits into from
Jun 30, 2022

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Jun 30, 2022

Description

Removing an unused saga action, and dragging with it some remaining eslint fixes after forcing prettier to run on commits

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Ole Martin Handeland added 5 commits June 29, 2022 13:07
# Conflicts:
#	src/altinn-app-frontend/src/features/form/dynamics/api/apiActions.ts
#	src/altinn-app-frontend/src/features/form/dynamics/api/apiSagas.ts
#	src/altinn-app-frontend/src/features/form/dynamics/formDynamicsActions.ts
#	src/altinn-app-frontend/src/features/form/dynamics/formDynamicsSagas.ts
# Conflicts:
#	src/altinn-app-frontend/setupTests.ts
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@olemartinorg olemartinorg marked this pull request as ready for review June 30, 2022 08:28
@olemartinorg olemartinorg requested a review from haakemon June 30, 2022 08:28
@olemartinorg olemartinorg merged commit 1f3205d into main Jun 30, 2022
@olemartinorg olemartinorg deleted the chore/cleanup-dead-code branch June 30, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants