Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken deep validations in nested repeating groups #2867

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

olemartinorg
Copy link
Contributor

Description

This bug was introduced because I didn't understand the concept in useDeepValidationsForNode() when refactoring, so I turned onlyChildren = true into "stop at depth 1" (i.e. only immediate children, not nested children) instead of the correct interpretation of "don't include validations on the node itself" (i.e. only get validations for children).

Added a cypress test for this as well, so that we don't end up doing the same mistake again. I removed the describe('Falsy values', () => { grouping in this test, because it's wrapping lots of tests that doesn't have to do with falsy values - ignore all the indent-changes in the cypress test.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Ole Martin Handeland added 3 commits January 3, 2025 13:40
@olemartinorg olemartinorg added the kind/bug Something isn't working label Jan 6, 2025
@olemartinorg olemartinorg merged commit cb3c328 into main Jan 6, 2025
16 checks passed
@olemartinorg olemartinorg deleted the bug/deep-validations branch January 6, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feilmelding vises ikke i ytre tabell i to repeterede nøsta grupper
2 participants