Broken deep validations in nested repeating groups #2867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug was introduced because I didn't understand the concept in
useDeepValidationsForNode()
when refactoring, so I turnedonlyChildren = true
into "stop at depth 1" (i.e. only immediate children, not nested children) instead of the correct interpretation of "don't include validations on the node itself" (i.e. only get validations for children).Added a cypress test for this as well, so that we don't end up doing the same mistake again. I removed the
describe('Falsy values', () => {
grouping in this test, because it's wrapping lots of tests that doesn't have to do with falsy values - ignore all the indent-changes in the cypress test.Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping