Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split by '.' only once when parsing 'dataSource' for a text resource variable #2802

Merged

Conversation

martinothamar
Copy link
Contributor

@martinothamar martinothamar commented Dec 10, 2024

Description

Make sure we only split dataSource by . once, so that if there are datatypes with the . character we still use the full datatype string when resolving datamodel references for variable substitution in text resources.

This was discovered by brreg dev, ref Slack thread: https://altinn.slack.com/archives/C02EJ9HKQA3/p1733736458716249

Related Issue(s)

  • N/A

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@martinothamar martinothamar added the kind/bug Something isn't working label Dec 10, 2024
@martinothamar martinothamar self-assigned this Dec 10, 2024
@martinothamar martinothamar merged commit f936ff6 into main Dec 12, 2024
14 checks passed
@martinothamar martinothamar deleted the fix/splitting-datasource-for-textresource-variables branch December 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants