Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky cypress test #228

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix flaky cypress test #228

merged 1 commit into from
Jun 16, 2022

Conversation

lorang92
Copy link
Contributor

Description

Verify that element actually is rendered before running the cypress evaluation. Caused flaky behavior.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the area/test related to automated and functional testing label Jun 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nkylstad
nkylstad approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@lorang92 lorang92 merged commit c53a978 into main Jun 16, 2022
@lorang92 lorang92 deleted the test/cypress-flaky-test branch June 16, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

Assignees
No one assigned
Labels
area/test related to automated and functional testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorang92 @nkylstad @lorangSec