Skip to content

Summary2: Groups #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 111 commits into from
Jul 29, 2024
Merged

Summary2: Groups #2208

merged 111 commits into from
Jul 29, 2024

Conversation

benjamindehli
Copy link
Contributor

@benjamindehli benjamindehli commented Jul 4, 2024 •
edited by olemartinorg
Loading

Description

  • Fixes rendering of nested groups
  • Adds support for compact groups

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

adamhaeger and others added 30 commits May 3, 2024 16:08
@adamhaeger
feat: added new summary component with config, can render child nodes
ab18b79
@adamhaeger
chore: removed uneeded changes
98ede54
@adamhaeger
chore: wip
fd8d8a3
@adamhaeger
wip
e67c61c
@adamhaeger
Merge branch 'main' into feat/2070-summary-component-2
6042b9c
@adamhaeger
feat: can render layoutSets and pages
7c27c36
@adamhaeger
feat: can render layoutSets, pages and components
9de862d
@adamhaeger
feat: added basic support for nested groups
5bb3991
@adamhaeger
chore: added anddress and started rednering different tasks
b95ac77
@Magnusrm
overwrite props
f66d691
@Magnusrm
wip
3bf7f54
@adamhaeger
feat: added support for overrides on component level
6895968
@adamhaeger
chore: made overrides optional
a1fb010
@adamhaeger
wip: figuring out how to render tasks
978708e
@Magnusrm
render instance with current task in summary
10d25a3
@Magnusrm
input component summary improvements
99a68ed
@adamhaeger
wip: can render previous task
ec8995d
@Magnusrm
support grid for summary2
8f5b279
@Magnusrm
add empty value tekst to input summary
a1bd397
@Magnusrm
add validation message to input summary
f32887a
@benjamindehli
Feat/2070 summary component 2: Added Radio group Feat/2060 and Checkb…
1044caf 
…ox group Feat/2061 (#2131)

* Add stylesheet for radio buttons summary

* Add summary2 for checkboxes

* Make displayType optional

* Add  support for override props
@Magnusrm
clean up inputsummary
e9e68ff
@Magnusrm
moove and rename inputSummary component
020b11a
@Magnusrm
update structure for radio and input summary
6ac02f5
@Magnusrm
update checkboxes summary
fbbe1aa
@adamhaeger
added accordion to summary page rendering
df1432f
@adamhaeger
cleanup
694f47f
@adamhaeger
merge
c5d064a
@adamhaeger
fixes after merge
ed4f3d5
@adamhaeger
merge
f0f255a
adamhaeger and others added 16 commits June 25, 2024 14:56
@adamhaeger
feat: made pages rendered in accordian opt-in
21fa0ac
@Magnusrm
fix header from labelfrom grid cell
882913f
@benjamindehli
Add temporary summary render for Headers
a24c849
@benjamindehli
Adjust font size for nested group headings
bf6ab72
@benjamindehli
Adjust spacing for elements inside group
5ed6323
@benjamindehli
Merge remote-tracking branch 'origin/feat/2070-summary-component-2' i…
6473e8f 
…nto feat/2062-group
@adamhaeger
Fix: fixed error locations on address
06b1352
@adamhaeger
Merge branch 'feat/2070-summary-component-2' of https://github.com/Al…
ace5eef 
…tinn/app-frontend-react into feat/2070-summary-component-2
@adamhaeger
cleanups after code review
44e26a0
@benjamindehli
Merge remote-tracking branch 'origin/feat/2070-summary-component-2' i…
91c623f 
…nto feat/2062-group
@adamhaeger
cleanup after PR
4ee456a
@benjamindehli
Merge 'origin/feat/2070-summary-component-2' into feat/2062-group
cca4022
@benjamindehli
Fix hierarchyLevel bump after merge
ee40e7d
@benjamindehli
Add support for compact display type for groups
33ca96d
@benjamindehli
Merge branch 'main' into feat/2062-group
7001647
@benjamindehli
Fix after merge
8fbb217
@benjamindehli benjamindehli added the kind/product-feature Pull requests containing new features label Jul 4, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 4, 2024
View reviewed changes
@Magnusrm Magnusrm assigned Magnusrm and benjamindehli and unassigned Magnusrm Jul 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Coverage on New Code (required ≥ 65%)
0.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@adamhaeger adamhaeger merged commit 1388b02 into main Jul 29, 2024
8 of 9 checks passed
@adamhaeger adamhaeger deleted the feat/2062-group branch July 29, 2024 10:58
@olemartinorg olemartinorg changed the title Feat/2062 group Summary2: Groups Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhaeger adamhaeger adamhaeger approved these changes

Assignees

@benjamindehli benjamindehli

Labels
kind/product-feature Pull requests containing new features
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamindehli @adamhaeger @Magnusrm